Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid warning for existing experimental flag #38027

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Fix invalid warning for existing experimental flag #38027

merged 1 commit into from
Jun 26, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 26, 2022

This ensures we don't incorrectly warn for this flag not existing when it does.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: slack thread

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jun 26, 2022
@ijjk ijjk merged commit 6781a52 into vercel:canary Jun 26, 2022
@ijjk ijjk deleted the fix/warning-for-existing-flag branch June 26, 2022 04:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cramforce cramforce cramforce approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @cramforce