Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-mux-video to use latest upchunk and replace video player with mux-player-react #37621

Merged
merged 12 commits into from
Jun 13, 2022
Merged

Update with-mux-video to use latest upchunk and replace video player with mux-player-react #37621

merged 12 commits into from
Jun 13, 2022

Conversation

clearlyTHUYDOAN
Copy link
Contributor

Description

Updates

  • upchunk to latest
  • Replace video player with mux-player-react
  • Remove unused video player code

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
    • There are 64 errors in 43 files on this branch however the same stats are also present on the canary branch
  • The examples guidelines are followed from our contributing doc
    • It should considering we are updating packages and removing unused code

@ijjk ijjk added the examples Issue/PR related to examples label Jun 10, 2022
leerob
leerob previously approved these changes Jun 11, 2022
View reviewed changes
balazsorban44
balazsorban44 previously approved these changes Jun 13, 2022
View reviewed changes
@balazsorban44 balazsorban44 dismissed stale reviews from leerob and themself via 6857390 June 13, 2022 11:37
ijjk
ijjk approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit 748cc51 into vercel:canary Jun 13, 2022
@clearlyTHUYDOAN
Copy link
Contributor Author

clearlyTHUYDOAN commented Jun 22, 2022 •
edited
Loading

Update: Figured it out! It's on our side. Thanks y'all.

Hi friends, not sure if you'll get this now that this has closed but curious what step needs to occur in order to have the deployed example reflect this update? I was looking for mux-player in the inspector but saw the old code.

No rush but want to know if I missed something / looking for context cc: @leerob. Thank you in advance! 🙏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@ijjk ijjk ijjk approved these changes

@leerob leerob leerob left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clearlyTHUYDOAN @leerob @balazsorban44 @ijjk