Fix invalid middleware regexp in manifest #37492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
timneutkens,
shuding,
padmaia and
huozhi
as code owners
timneutkens
approved these changes
Jun 6, 2022
Schniz
approved these changes
Jun 6, 2022
| files: ['server/edge-runtime-webpack.js', 'server/middleware.js'], | ||
| name: 'middleware', | ||
| page: '/', | ||
| regexp: '^/.*$', |
There was a problem hiding this comment.
What was the value prior to the change? An empty string?
There was a problem hiding this comment.
Yeah an empty string so it passed the nullish check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes invalid
regexpbeing output in the middleware manifest causing deployments to fail and invalid regex to be used for matching locally. Our E2E tests caught this after the canary publish although I have added additional integration tests to catch this earlier.Bug
fixes #numbercontributing.mdx-ref: #37177
Fixes: https://github.com/vercel/next.js/runs/6762816907?check_suite_focus=true