Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify "When does getStaticProps run" note #37289

Merged
merged 3 commits into from
May 29, 2022

Conversation

Clariity
Copy link
Contributor

Changed bullet points to say "getStaticPaths" instead of "getStaticProps".

Fixes #37288

Feature

  • Related issues linked using fixes #number
  • Documentation added

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Changed bullet points to say "getStaticPaths" instead of "getStaticProps".
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is correct as is x-ref: #36722 is there something here that we could re-word to make this more clear?

@Clariity
Copy link
Contributor Author

@ijjk I think it could be clearer if put in a sub section titled something like "How does getStaticProps run with regards to getStaticPaths" so we know we are definitely talking about getStaticProps.

@ijjk
Copy link
Member

ijjk commented May 29, 2022

That sounds like a good update, wanna apply that on this branch?

@Clariity
Copy link
Contributor Author

sure, I'll do that now

Clariity and others added 2 commits May 29, 2022 23:12
Clarify mention of getStaticProps within getStaticPaths docs
@ijjk ijjk changed the title [docs] Correct "When does getStaticPaths run" bullets [docs] Clarify "When does getStaticProps run" note May 29, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit f4dcb81 into vercel:canary May 29, 2022
@Clariity Clariity deleted the fix-37288 branch May 29, 2022 22:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: getStaticPaths "When does getStaticPaths run" error
2 participants