Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning during build if page is returning a large amount of data #37264

Merged

Conversation

sshyam-gupta
Copy link
Contributor

@sshyam-gupta sshyam-gupta commented May 28, 2022

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes Show warning during build if page is returning a large amount of data #33829
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member

ijjk commented May 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
buildDuration 15.7s 15.3s -449ms
buildDurationCached 6.6s 6.1s -543ms
nodeModulesSize 626 MB 626 MB ⚠️ +687 B
Page Load Tests Overall increase ✓
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
/ failed reqs 0 0
/ total time (seconds) 3.89 3.806 -0.08
/ avg req/sec 642.73 656.79 +14.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.462 1.213 -0.25
/error-in-render avg req/sec 1710.04 2060.76 +350.72
Client Bundles (main, webpack)
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.7 kB 2.7 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
buildDuration 17.3s 18.3s ⚠️ +984ms
buildDurationCached 6.4s 5.9s -579ms
nodeModulesSize 626 MB 626 MB ⚠️ +687 B
Page Load Tests Overall increase ✓
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
/ failed reqs 0 0
/ total time (seconds) 5.622 3.585 -2.04
/ avg req/sec 444.7 697.44 +252.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.359 1.437 ⚠️ +0.08
/error-in-render avg req/sec 1839.68 1739.63 ⚠️ -100.05
Client Bundles (main, webpack)
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74.1 kB 74.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.9 kB 2.9 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary sshyam-gupta/next.js show-build-warning-for-large-data Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 3eccb26

@sshyam-gupta sshyam-gupta marked this pull request as ready for review May 28, 2022 15:29
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 3930214 into vercel:canary May 29, 2022
@sshyam-gupta sshyam-gupta deleted the show-build-warning-for-large-data branch May 30, 2022 06:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show warning during build if page is returning a large amount of data
2 participants