Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(actions): skip plugin features for non supported platform #37229

Merged
merged 4 commits into from
May 27, 2022

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented May 27, 2022

Bug

Trying to workaround failures https://github.com/vercel/next.js/runs/6618358220?check_suite_focus=true for the platforms we can't support plugins.

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint
  • The examples guidelines are followed from our contributing doc

@ijjk
Copy link
Member

ijjk commented May 27, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
buildDuration 17.3s 17.2s -97ms
buildDurationCached 6.7s 6.5s -227ms
nodeModulesSize 626 MB 626 MB ⚠️ +106 B
Page Load Tests Overall increase ✓
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
/ failed reqs 0 0
/ total time (seconds) 4.819 4.477 -0.34
/ avg req/sec 518.76 558.42 +39.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.952 1.643 -0.31
/error-in-render avg req/sec 1280.78 1521.88 +241.1
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
buildDuration 19.3s 20.7s ⚠️ +1.5s
buildDurationCached 6.4s 6.3s -110ms
nodeModulesSize 626 MB 626 MB ⚠️ +106 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
/ failed reqs 0 0
/ total time (seconds) 4.646 4.684 ⚠️ +0.04
/ avg req/sec 538.15 533.76 ⚠️ -4.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.759 1.828 ⚠️ +0.07
/error-in-render avg req/sec 1421.01 1367.82 ⚠️ -53.19
Client Bundles (main, webpack)
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.9 kB 2.9 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kwonoj/next.js build-skip-plugin-no-supported-targets Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: e6bb7f9

This reverts commit 50bdb97.
@ijjk ijjk merged commit 951b29e into vercel:canary May 27, 2022
@kwonoj kwonoj deleted the build-skip-plugin-no-supported-targets branch May 27, 2022 01:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants