Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build-wasm CI job #37165

Merged
merged 4 commits into from
May 24, 2022
Merged

Fix build-wasm CI job #37165

merged 4 commits into from
May 24, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 24, 2022 •
edited
Loading

Updates to use a macos runner as it seems we are hitting a core dump error while optimizing the wasm binary on ubuntu.

x-ref: https://github.com/vercel/next.js/runs/6579658792?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6579658710?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/6575220783?check_suite_focus=true
x-ref: slack thread

potentially related: rustwasm/wasm-pack#781

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label May 24, 2022
@ijjk
Copy link
Member Author

ijjk commented May 24, 2022 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/build-wasm Change
buildDuration 14.7s 15.5s ⚠️ +738ms
buildDurationCached 6s 6.6s ⚠️ +567ms
nodeModulesSize 494 MB 494 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/build-wasm Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.684 3.547 -0.14
/ avg req/sec 678.7 704.79 +26.09
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.371 1.328 -0.04
/error-in-render avg req/sec 1823.01 1882.02 +59.01
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/build-wasm Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 29.2 kB 29.2 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 73 kB 73 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/build-wasm Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/build-wasm Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 308 B 308 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 359 B 359 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.74 kB 5.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.65 kB 2.65 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 391 B 391 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16 kB 16 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/build-wasm Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/build-wasm Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/build-wasm Change
buildDuration 17.1s 17.2s ⚠️ +140ms
buildDurationCached 5.9s 5.8s -74ms
nodeModulesSize 494 MB 494 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/build-wasm Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.752 3.662 -0.09
/ avg req/sec 666.39 682.69 +16.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.321 1.297 -0.02
/error-in-render avg req/sec 1892.86 1927.63 +34.77
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/build-wasm Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.7 kB 42.7 kB ✓
main-HASH.js gzip 29.7 kB 29.7 kB ✓
webpack-HASH.js gzip 1.54 kB 1.54 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/build-wasm Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/build-wasm Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 311 B 311 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.89 kB 2.89 kB ✓
head-HASH.js gzip 357 B 357 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.84 kB 5.84 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.78 kB 2.78 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 392 B 392 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 16.4 kB 16.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/build-wasm Change
_buildManifest.js gzip 457 B 457 B ✓
Overall change 457 B 457 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/build-wasm Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 489715c

@ijjk ijjk marked this pull request as ready for review May 24, 2022 20:30
styfle
styfle approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last I checked, the macos runner has reduced concurrency so we'll see if this gets stuck in queued more often

@ijjk ijjk merged commit 9063b19 into vercel:canary May 24, 2022
@ijjk ijjk deleted the fix/build-wasm branch May 24, 2022 20:49
Schniz pushed a commit to Schniz/next.js that referenced this pull request May 25, 2022
@ijjk @Schniz
Fix build-wasm CI job (vercel#37165)
c76e5c8 
* Fix build-wasm CI job

* use macos

* re-add release check
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@styfle styfle styfle approved these changes

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @styfle @timneutkens