Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes beforeInteractive inline scripts don't run #37033

Merged
merged 2 commits into from
May 19, 2022

Conversation

Chastrlove
Copy link
Contributor

BeforeInteractive inline script in v12.1.7-canary.8 don't run. Beacause the script has unknow src.

image

Fixes #31275

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented May 19, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
buildDuration 15.7s 15.8s ⚠️ +118ms
buildDurationCached 6.3s 6.3s ⚠️ +23ms
nodeModulesSize 478 MB 478 MB ⚠️ +22 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
/ failed reqs 0 0
/ total time (seconds) 3.777 3.816 ⚠️ +0.04
/ avg req/sec 661.92 655.1 ⚠️ -6.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.206 1.206
/error-in-render avg req/sec 2073.32 2073.62 +0.3
Client Bundles (main, webpack)
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
buildDuration 18.1s 18.2s ⚠️ +130ms
buildDurationCached 6.3s 6.3s -18ms
nodeModulesSize 478 MB 478 MB ⚠️ +22 B
Page Load Tests Overall increase ✓
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
/ failed reqs 0 0
/ total time (seconds) 3.811 3.779 -0.03
/ avg req/sec 655.97 661.63 +5.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.207 1.165 -0.04
/error-in-render avg req/sec 2071.78 2146.2 +74.42
Client Bundles (main, webpack)
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.5 kB 29.5 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.8 kB 73.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary Chastrlove/next.js fix/inline-script Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 9657bb4

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change and added test looks good, thanks for the PR!

@kodiakhq kodiakhq bot merged commit 5b21f09 into vercel:canary May 19, 2022
@housseindjirdeh
Copy link
Collaborator

Thanks for the PR @Chastrlove. A recent update we've made is trying to move developers to only using beforeInteractive within _document.js. Were you seeing an issue when you added a beforeInteractive script to the custom document or in a specific page? If it's the latter, just be careful since we're considering enforcing developers to only include beforeInteractive scripts at the document-level to support React streaming, but this isn't fully confirmed just yet (however our docs have been updated to reflect this).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use dangerouslySetInnerHTML and beforeInteractive strategy in Script component
3 participants