Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with-markdoc/ example #36867

Merged
merged 15 commits into from
May 18, 2022
Merged

Add with-markdoc/ example #36867

merged 15 commits into from
May 18, 2022

Conversation

mfix-stripe
Copy link
Contributor

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label May 12, 2022
leerob
leerob reviewed May 13, 2022
View reviewed changes
examples/with-markdoc/package.json Outdated Show resolved Hide resolved
examples/with-markdoc/README.md Outdated Show resolved Hide resolved
@mfix-stripe
Copy link
Contributor Author

I think this should be good now @leerob! Would you rather I name the folder markdoc/ or with-markdoc/?

leerob
leerob previously approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

leerob
leerob reviewed May 13, 2022
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to add a .gitignore that matches the other examples.

@balazsorban44
Copy link
Member

balazsorban44 commented May 13, 2022 •
edited
Loading

Heads up, there was another example being added in this PR: #36850

I think we should only merge one of them, and preferably use TypeScript either way. 👍

@balazsorban44 balazsorban44 mentioned this pull request May 13, 2022
Closed
10 tasks
@mfix-stripe
Copy link
Contributor Author

Heads up, there was another example being added in this PR: #36850

I think we should only merge one of them, and preferably use TypeScript either way. 👍

Let's use this PR. We will get this updated to TypeScript. (Cc @hideokamoto)

@hideokamoto-stripe
Copy link
Contributor

@mfix-stripe
I've made a new PR to your branch.
mfix-stripe#1

Please review and merge it. 👍

leerob
leerob previously approved these changes May 18, 2022
View reviewed changes
@mfix-stripe
Copy link
Contributor Author

@leerob had to fix Prettier, sorry!

ijjk
ijjk previously approved these changes May 18, 2022
View reviewed changes
@mfix-stripe
Copy link
Contributor Author

@ijjk ran into a lint error, so had to push 016a095. Hopefully this is good now!

@ijjk ijjk merged commit 91c75b6 into vercel:canary May 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob leerob left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfix-stripe @balazsorban44 @hideokamoto-stripe @leerob @ijjk