keep method when cloning Request, fixes #36522

[gazs]

This fixes #36522 by copying the method from the input Request object when constructing a new one. A new unit test is added to verify this.

Fixes: #36522

Bug

• Related issues linked using fixes #36522
• [n/a] Integration tests added
• [n/a] Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes by running yarn lint

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
buildDuration	15.9s	15.8s	-132ms
buildDurationCached	6.5s	6.5s	-47ms
nodeModulesSize	479 MB	479 MB	⚠️ +245 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.845	3.853	⚠️ +0.01
/ avg req/sec	650.2	648.85	⚠️ -1.35
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.306	1.316	⚠️ +0.01
/error-in-render avg req/sec	1913.82	1899.02	⚠️ -14.8

Client Bundles (main, webpack)

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	29.1 kB	29.1 kB	✓
webpack-HASH.js gzip	1.54 kB	1.54 kB	✓
Overall change	72.8 kB	72.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	308 B	308 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	359 B	359 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.73 kB	5.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.65 kB	2.65 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	391 B	391 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16 kB	16 kB	✓

Client Build Manifests

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
index.html gzip	532 B	532 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
buildDuration	18s	18.1s	⚠️ +88ms
buildDurationCached	6.5s	6.6s	⚠️ +78ms
nodeModulesSize	479 MB	479 MB	⚠️ +245 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.863	3.862	0
/ avg req/sec	647.16	647.41	+0.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.299	1.323	⚠️ +0.02
/error-in-render avg req/sec	1925.03	1890.22	⚠️ -34.81

Client Bundles (main, webpack)

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.7 kB	42.7 kB	✓
main-HASH.js gzip	29.6 kB	29.6 kB	✓
webpack-HASH.js gzip	1.54 kB	1.54 kB	✓
Overall change	74 kB	74 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	2.89 kB	2.89 kB	✓
head-HASH.js gzip	357 B	357 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.82 kB	5.82 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.78 kB	2.78 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	392 B	392 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	16.3 kB	16.3 kB	✓

Client Build Manifests

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
_buildManifest.js gzip	457 B	457 B	✓
Overall change	457 B	457 B	✓

Rendered Page Sizes

	vercel/next.js canary	gazs/next.js request-clone-keep-method	Change
index.html gzip	532 B	532 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 0603cba

[SukkaW]

Suggested change

	const method =
	init.method?.toUpperCase() ??
	(input instanceof BaseRequest ? input.method?.toUpperCase() : 'GET')
	const method = init.method?.toUpperCase() ??
	(typeof input !== 'string' ? input.method?.toUpperCase() : 'GET')

The performant way to add type guard here.

[ijjk]

Would we also need to update the checks to consider input being nullish if we check for !== 'string' here?

[ijjk]

Thanks for the PR!