Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Tina + Adding a demo URL #35480

Merged
merged 9 commits into from
May 10, 2022
Merged

Fixing Tina + Adding a demo URL #35480

merged 9 commits into from
May 10, 2022

Conversation

perkinsjr
Copy link
Contributor

@perkinsjr perkinsjr commented Mar 21, 2022 •
edited
Loading

Documentation / Examples

  • Updating Tina Demo URL
  • Adding Tina to blog-starter example
  • Adding Tina to Basic features section
  • Updating Tina to actually work again

Adding:
4cba003 
- Tina Demo URL
- Tina to blog-starter example
- Adding Tina to Basic features section
@ijjk ijjk added area: documentation examples Issue/PR related to examples labels Mar 21, 2022
@perkinsjr perkinsjr changed the title Adding: Adding Tina to appropriate sections and Updating Tina Demo URL Mar 21, 2022
Adding Tina Updates
45f7379 
- The current example is broken without the changes.
@perkinsjr perkinsjr changed the title Adding Tina to appropriate sections and Updating Tina Demo URL Fixing Tina + Adding a demo URL May 10, 2022
@perkinsjr
Copy link
Contributor Author

Looking for someone to approve this PR... The current implementation doesn't work as we made some changes to Tina to be faster and easier.

leerob
leerob approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit 22c0b65 into vercel:canary May 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perkinsjr @leerob @ijjk