Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make concurrent features independent from the global runtime option" #35405

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 17, 2022

Reverts #35245

@ijjk
Copy link
Member

ijjk commented Mar 17, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
buildDuration 19s 18.9s -116ms
buildDurationCached 7.5s 7.4s -120ms
nodeModulesSize 456 MB 456 MB -1.73 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
/ failed reqs 0 0
/ total time (seconds) 3.784 3.774 -0.01
/ avg req/sec 660.65 662.46 +1.81
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.635 1.612 -0.02
/error-in-render avg req/sec 1529.42 1550.7 +21.28
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
buildDuration 22.8s 22.8s ⚠️ +13ms
buildDurationCached 7.4s 7.4s -13ms
nodeModulesSize 456 MB 456 MB -1.73 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
/ failed reqs 0 0
/ total time (seconds) 3.793 3.8 ⚠️ +0.01
/ avg req/sec 659.05 657.97 ⚠️ -1.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.665 1.662 0
/error-in-render avg req/sec 1501.21 1504.06 +2.85
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-35245-shu/c393 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 201c7cf

@kodiakhq kodiakhq bot merged commit 24f450e into canary Mar 17, 2022
@kodiakhq kodiakhq bot deleted the revert-35245-shu/c393 branch March 17, 2022 16:31
huozhi added a commit to huozhi/next.js that referenced this pull request Mar 22, 2022
huozhi added a commit to huozhi/next.js that referenced this pull request Mar 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants