Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/with-segment-analytics): Update README #35387

Merged
merged 3 commits into from
May 22, 2022
Merged

fix(examples/with-segment-analytics): Update README #35387

merged 3 commits into from
May 22, 2022

Conversation

elskwid
Copy link
Contributor

@elskwid elskwid commented Mar 17, 2022

Update the README for examples/with-segment-analytics:

  • Update reference from _document.js (removed in 92d8787) to _app.js.
  • Update reference links
  • Make small language tweaks

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@elskwid
fix(examples/with-segment-analytics): Update README
56f2137 
Update the README for `examples/with-segment-analytics`:

- Update reference from `_document.js` (removed in 92d8787) to `_app.js`.
- Update reference links
- Make small language tweaks
@ijjk ijjk added the examples Issue/PR related to examples label Mar 17, 2022
@ijjk ijjk requested a review from balazsorban44 as a code owner May 22, 2022 04:17
ijjk
ijjk approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 3c001aa into vercel:canary May 22, 2022
@elskwid
Copy link
Contributor Author

elskwid commented May 24, 2022

Thanks, @ijjk!

@snyk-bot snyk-bot mentioned this pull request May 30, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elskwid @ijjk