Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): Update swc #33628

Merged
merged 2 commits into from
Jan 25, 2022
Merged

feat(next-swc): Update swc #33628

merged 2 commits into from
Jan 25, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 25, 2022

@ijjk
Copy link
Member

ijjk commented Jan 25, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js swc-up-9 Change
buildDuration 15.6s 15.5s -40ms
buildDurationCached 4.1s 4.1s ⚠️ +23ms
nodeModulesSize 356 MB 356 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-9 Change
/ failed reqs 0 0
/ total time (seconds) 3.622 3.708 ⚠️ +0.09
/ avg req/sec 690.31 674.26 ⚠️ -16.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.775 1.655 -0.12
/error-in-render avg req/sec 1408.47 1510.2 +101.73
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-9 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-9 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-9 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.87 kB 4.87 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-9 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-9 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary kdy1/next.js swc-up-9 Change
buildDuration 19.7s 19.5s -198ms
buildDurationCached 4.2s 4.2s ⚠️ +5ms
nodeModulesSize 356 MB 356 MB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-9 Change
/ failed reqs 0 0
/ total time (seconds) 3.74 3.513 -0.23
/ avg req/sec 668.42 711.55 +43.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.704 1.628 -0.08
/error-in-render avg req/sec 1466.88 1535.39 +68.51
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-9 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-9 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-9 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.89 kB 4.89 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-9 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-9 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB
Commit: cabee56

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next.js seems to be handling JS closures incorrectly
3 participants