-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify getMiddlewareInfo calls #33542
Conversation
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: 09c4949 test/integration/absolute-assetprefix/test/index.test.js
Expand output● absolute assetPrefix with path prefix › should not fetch static data from a CDN
● absolute assetPrefix with path prefix › should fetch from cache correctly
● absolute assetPrefix with path prefix › should work with getStaticPaths prerendered
● absolute assetPrefix with path prefix › should work with getStaticPaths fallback
● absolute assetPrefix with path prefix › should work with getServerSideProps
test/integration/amphtml-custom-validator/test/index.test.js
Expand output● AMP Custom Validator › should build and start successfully
test/integration/amphtml-fragment-style/test/index.test.js
Expand output● AMP Fragment Styles › adds styles from fragment in AMP mode correctly
● Test suite failed to run
test/integration/app-document-style-fragment/test/index.test.js
Expand output● Custom Document Fragment Styles › correctly adds styles from fragment styles key
● Test suite failed to run
test/production/fallback-export-error/index.test.ts
Expand output● fallback export error › should have built
test/integration/basepath-root-catch-all/test/index.test.js
Expand output● production mode › should use correct data URL for root catch-all
● serverless mode › should use correct data URL for root catch-all
test/integration/404-page-app/test/index.test.js
Expand output● 404 Page Support with _app › production mode › should not output static 404 if _app has getInitialProps
● 404 Page Support with _app › production mode › should still use 404 page
|
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.959 | 2.964 | 0 |
/ avg req/sec | 844.77 | 843.34 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.381 | 1.387 | |
/error-in-render avg req/sec | 1810.85 | 1801.86 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 27.2 kB | 27.2 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71 kB | 71 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 919 B | 919 B | ✓ |
image-HASH.js gzip | 4.87 kB | 4.87 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.2 kB | 14.2 kB | ✓ |
Client Build Manifests
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 546 B | 546 B | ✓ |
withRouter.html gzip | 527 B | 527 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
buildDuration | 15.7s | 16s | |
buildDurationCached | 3.2s | 3.2s | |
nodeModulesSize | 355 MB | 355 MB | -396 B |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.011 | 2.998 | -0.01 |
/ avg req/sec | 830.26 | 833.86 | +3.6 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.341 | 1.361 | |
/error-in-render avg req/sec | 1864.06 | 1836.45 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 27.3 kB | 27.3 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 71.3 kB | 71.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 911 B | 911 B | ✓ |
image-HASH.js gzip | 4.89 kB | 4.89 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.2 kB | 14.2 kB | ✓ |
Client Build Manifests
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | huozhi/next.js bs/simplify | Change | |
---|---|---|---|
index.html gzip | 530 B | 530 B | ✓ |
link.html gzip | 544 B | 544 B | ✓ |
withRouter.html gzip | 525 B | 525 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Seems JJ bot outdated comment is not hidden? @ijjk |
Subtask of vercel#31506 * move `serverBuildDir` and getter function of `publicDir` to next-server as only used place * simplify `getMiddlewareInfo`, remove `distDir` and other params could be accessed from web server itself
Subtask of #31506
serverBuildDir
and getter function ofpublicDir
to next-server as only used placegetMiddlewareInfo
, removedistDir
and other params could be accessed from web server itself