Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next-swc: fix ssg code elimination when used in render #32709

Merged
merged 5 commits into from
Jan 11, 2022
Merged

next-swc: fix ssg code elimination when used in render #32709

merged 5 commits into from
Jan 11, 2022

Conversation

pveyes
Copy link
Contributor

@pveyes pveyes commented Dec 21, 2021 •
edited
Loading

This PR marks all JSXElement AST nodes to make sure that any components used inside both render and SSG exports are not removed

Fixes #31536

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk
Copy link
Member

ijjk commented Jan 8, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
buildDuration 14.1s 14.4s ⚠️ +371ms
buildDurationCached 3.1s 3.1s ⚠️ +4ms
nodeModulesSize 348 MB 348 MB ⚠️ +5 B
Page Load Tests Overall increase ✓
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.881 2.908 ⚠️ +0.03
/ avg req/sec 867.86 859.71 ⚠️ -8.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.327 1.306 -0.02
/error-in-render avg req/sec 1884.24 1914.1 +29.86
Client Bundles (main, webpack, commons)
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
buildDuration 15.5s 15.4s -111ms
buildDurationCached 3.2s 3.1s -41ms
nodeModulesSize 348 MB 348 MB ⚠️ +5 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.878 2.882 0
/ avg req/sec 868.54 867.35 ⚠️ -1.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.322 1.327 0
/error-in-render avg req/sec 1890.64 1884.03 ⚠️ -6.61
Client Bundles (main, webpack, commons)
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary pveyes/next.js swc-fix-ssg-code-elimination Change
index.html gzip 531 B 531 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: abecb0d

kdy1
kdy1 approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pveyes pveyes marked this pull request as ready for review January 9, 2022 07:09
@balazsorban44 balazsorban44 merged commit 600f113 into vercel:canary Jan 11, 2022
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 11, 2022
@teleaziz
Merge branch 'cms-builder-io-example' of github.com:teleaziz/next.js …
ce988af 
…into cms-builder-io-example

* 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits)
  drop dynamic import with `ssr: false` on server-side (vercel#32606)
  next-swc: fix ssg code elimination when used in render (vercel#32709)
  Add Caveats section to custom error page (vercel#33160)
  v12.0.8-canary.20
  Allow dependencies to use environment variables in middlewares (vercel#33141)
  use a separate webpack runtime for middleware (vercel#33134)
  No info on environment variables in the src folder (vercel#33110) (vercel#33136)
  docs: minor text-copy cleanup (vercel#33120)
  Update swc (vercel#33063)
  Update next.config.js (vercel#33091)
  Adding Asset Component for Rich Text Renderer (vercel#32503)
  Update using-mdx.md (vercel#33077)
  v12.0.8-canary.19
  Fix middleware at root in standalone mode (vercel#33053)
  Add util for generating new tests/error documents (vercel#33001)
  Remove extra config from tailwind example (vercel#33062)
  Fix link for Next.js Analytics in docs (vercel#33049)
  Bump `@vercel/nft` to 0.17.2 (vercel#33048)
  Update deployment documentation. (vercel#32006)
  v12.0.8-canary.18
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwanted code elimination when using a component in getStaticProps
4 participants
@pveyes @ijjk @kdy1 @balazsorban44