Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped isomorphic-fetch in examples in favor of isomorphic-unfetch. #3230

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Conversation

lquixada
Copy link
Contributor

@lquixada lquixada commented Nov 2, 2017

No description provided.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timneutkens timneutkens merged commit b41d177 into vercel:canary Nov 4, 2017
@remy
Copy link
Contributor

remy commented Nov 4, 2017

Can I ask what's the favour here? Only because when I first came across unfetch I actually assumed it was a dodgy package. Had to do some serious validation before I was convinced it wasn't a typo squat.

@timneutkens
Copy link
Member

timneutkens commented Nov 4, 2017

@remy the reason is explained here 👌
#3146 (comment)

It's kinda unfortunate there's no readme in the npm package of isomorphic-unfetch. I've already fixed that with a PR.

@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants