Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base-server #32058

Closed
wants to merge 1 commit into from
Closed

Base-server #32058

wants to merge 1 commit into from

Conversation

karaggeorge
Copy link
Contributor

@karaggeorge karaggeorge commented Dec 2, 2021

@ijjk ijjk added the type: next label Dec 2, 2021
@ijjk
Copy link
Member

ijjk commented Dec 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js base-server Change
buildDuration 24.7s 23.7s -954ms
buildDurationCached 4.4s 4.1s -332ms
nodeModulesSize 347 MB 347 MB ⚠️ +169 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js base-server Change
/ failed reqs 0 0
/ total time (seconds) 4.15 3.971 -0.18
/ avg req/sec 602.44 629.56 +27.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.121 2.082 -0.04
/error-in-render avg req/sec 1178.47 1200.78 +22.31
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js base-server Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js base-server Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js base-server Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js base-server Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js base-server Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js base-server Change
buildDuration 24.5s 25.9s ⚠️ +1.5s
buildDurationCached 4.1s 4.2s ⚠️ +9ms
nodeModulesSize 347 MB 347 MB ⚠️ +169 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js base-server Change
/ failed reqs 0 0
/ total time (seconds) 3.947 4.029 ⚠️ +0.08
/ avg req/sec 633.39 620.44 ⚠️ -12.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.981 2.088 ⚠️ +0.11
/error-in-render avg req/sec 1261.71 1197.24 ⚠️ -64.47
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js base-server Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js base-server Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js base-server Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js base-server Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js base-server Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: ca14ddf

@ijjk
Copy link
Member

ijjk commented Dec 2, 2021

Failing test suites

Commit: ca14ddf

test/integration/image-component/base-path/test/static.test.js

  • Static Image Component Tests for basePath > dev mode > Should allow an image with a static src to omit height and width
  • Static Image Component Tests for basePath > dev mode > Should use immutable cache-control header for static import
  • Static Image Component Tests for basePath > dev mode > Should automatically provide an image height and width
  • Static Image Component Tests for basePath > dev mode > Should allow provided width and height to override intrinsic
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported jpg
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported png
  • Static Image Component Tests for basePath > production mode > Should allow an image with a static src to omit height and width
  • Static Image Component Tests for basePath > production mode > Should use immutable cache-control header for static import
  • Static Image Component Tests for basePath > production mode > Should use immutable cache-control header even when unoptimized
  • Static Image Component Tests for basePath > production mode > Should automatically provide an image height and width
  • Static Image Component Tests for basePath > production mode > Should allow provided width and height to override intrinsic
  • Static Image Component Tests for basePath > production mode > Should add a blur placeholder to statically imported jpg
  • Static Image Component Tests for basePath > production mode > Should add a blur placeholder to statically imported png
Expand output

● Static Image Component Tests for basePath › production mode › Should allow an image with a static src to omit height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:43269/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should use immutable cache-control header for static import

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:43269/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should use immutable cache-control header even when unoptimized

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:43269/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should automatically provide an image height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:43269/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should allow provided width and height to override intrinsic

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:43269/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should add a blur placeholder to statically imported jpg

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:43269/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › production mode › Should add a blur placeholder to statically imported png

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:43269/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:78:23

● Static Image Component Tests for basePath › dev mode › Should allow an image with a static src to omit height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:46617/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should use immutable cache-control header for static import

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:46617/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should automatically provide an image height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:46617/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should allow provided width and height to override intrinsic

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:46617/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported jpg

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:46617/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported png

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:46617/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

@shuding shuding mentioned this pull request Dec 2, 2021
10 tasks
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as this appears to be superseded by #32154

@ijjk ijjk closed this May 22, 2022
@ijjk ijjk deleted the base-server branch May 22, 2022 22:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants