Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Adds test to data-nimg data attribute based on layout prop. #28444

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Tests: Adds test to data-nimg data attribute based on layout prop. #28444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d37fdf
Tests: Adds test to data-nimg data attribute based on layout prop.
andersonleite Aug 24, 2021
5483332
Merge branch 'canary' into data-nimg-tests
andersonleite Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/integration/image-component/basic/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,14 @@ describe('Image Component Tests', () => {
it('should not create any preload tags higher up the page than CSS preload tags', async () => {
expect(await hasImagePreloadBeforeCSSPreload()).toBe(false)
})
it('should add data-nimg data attribute based on layout', async () => {
expect(
await browser.elementById('image-with-sizes').getAttribute('data-nimg')
).toBe('responsive')
expect(
await browser.elementById('basic-image').getAttribute('data-nimg')
).toBe('intrinsic')
})
})
describe('Client-side Image Component Tests', () => {
beforeAll(async () => {
Expand Down