Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing file in mini-css-extract-plugin #25691

Merged
merged 5 commits into from
May 23, 2022
Merged

Add missing file in mini-css-extract-plugin #25691

merged 5 commits into from
May 23, 2022

Conversation

TxHawks
Copy link
Contributor

@TxHawks TxHawks commented Jun 1, 2021

Adds the hmr/hotModuleReplacement.js file to the compiled output
that is used in
packages/next/build/webpack/plugins/mini-css-extract-plugin.ts.

Fixes #25560

Bug

  • Related issues linked using fixes #number
  • Integration tests added

@TxHawks
add missing file in mini-css-extract-plugin
3193c34 
Adds the `hmr/hotModuleReplacement.js` file to the compiled output that
is used in
`packages/next/build/webpack/plugins/mini-css-extract-plugin.ts`.

Fixes vercel#25560
@ijjk ijjk added the type: next label Jun 1, 2021
@TxHawks TxHawks mentioned this pull request Jun 1, 2021
Closed
@ijjk

This comment has been minimized.

Sign in to view
@TxHawks
Copy link
Contributor Author

TxHawks commented Jun 2, 2021

@sokra Any chance you can take a look at this?

@ijjk
Copy link
Member

ijjk commented Jun 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
buildDuration 14.7s 14.6s -116ms
buildDurationCached 4s 4.1s ⚠️ +115ms
nodeModulesSize 46.7 MB 46.8 MB ⚠️ +3.09 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.596 2.653 ⚠️ +0.06
/ avg req/sec 963.14 942.42 ⚠️ -20.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.342 1.36 ⚠️ +0.02
/error-in-render avg req/sec 1863.47 1837.71 ⚠️ -25.76
Client Bundles (main, webpack, commons)
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.5 kB 19.5 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.53 kB 8.53 kB ✓
Client Build Manifests
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
index.html gzip 560 B 560 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
buildDuration 17s 16.5s -471ms
buildDurationCached 5.2s 5.1s -129ms
nodeModulesSize 46.7 MB 46.8 MB ⚠️ +3.09 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.5 kB 19.5 kB ✓
webpack-HASH.js gzip 804 B 804 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.07 kB 3.07 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 333 B 333 B ✓
withRouter-HASH.js gzip 330 B 330 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.53 kB 8.53 kB ✓
Client Build Manifests
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
_error.js 16.9 kB 16.9 kB -2 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ⚠️ +2 B
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
buildDuration 13.2s 13.3s ⚠️ +52ms
buildDurationCached 5.8s 5.6s -181ms
nodeModulesSize 46.7 MB 46.8 MB ⚠️ +3.09 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.731 2.695 -0.04
/ avg req/sec 915.5 927.63 +12.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.415 1.453 ⚠️ +0.04
/error-in-render avg req/sec 1766.45 1720.05 ⚠️ -46.4
Client Bundles (main, webpack, commons)
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.63 kB 1.63 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.37 kB 9.37 kB ✓
Client Build Manifests
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary TxHawks/next.js fix/mini-css-extract-hmr Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: db7b859

@kodiakhq kodiakhq bot merged commit 2872df5 into vercel:canary May 23, 2022
@SukkaW SukkaW mentioned this pull request Jun 2, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mini-css-extract-plugin hmr broken after #24573
2 participants
@TxHawks @ijjk