Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add strip-ansi babel include #25146

Merged
merged 2 commits into from
May 16, 2021
Merged

Re-add strip-ansi babel include #25146

merged 2 commits into from
May 16, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 14, 2021

This re-adds the strip-ansi babel include regex from #25101 since it seems to be needed still for the ie11 dev tests that are currently failing

x-ref: https://github.com/vercel/next.js/pull/25101/files

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member Author

ijjk commented May 14, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
buildDuration 14.7s 14.7s ⚠️ +20ms
buildDurationCached 4.4s 4.3s -80ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +95 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.503 2.486 -0.02
/ avg req/sec 998.69 1005.6 +6.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.506 1.478 -0.03
/error-in-render avg req/sec 1659.49 1691.02 +31.53
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
index.html gzip 560 B 560 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 556 B 556 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
buildDuration 18.6s 18.1s -527ms
buildDurationCached 6.4s 6.4s -28ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +95 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.4 MB 1.4 MB ✓
withRouter.js 1.4 MB 1.4 MB ⚠️ +2 B
Overall change 6.91 MB 6.91 MB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
buildDuration 12s 12.6s ⚠️ +565ms
buildDurationCached 5.3s 5.1s -214ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +95 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.598 2.536 -0.06
/ avg req/sec 962.16 985.97 +23.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.485 1.494 ⚠️ +0.01
/error-in-render avg req/sec 1683.06 1673.67 ⚠️ -9.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js revert/strip-ansi-include Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 4e2c14d

@timneutkens timneutkens merged commit 68ecbdd into vercel:canary May 16, 2021
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@ijjk
Re-add strip-ansi babel include (vercel#25146)
027665a
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens