Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scriptloader option names #25012

Merged
merged 2 commits into from
May 12, 2021

Conversation

janicklas-ralph
Copy link
Contributor

Refactor the ScriptLoader option names to be consistent with our design

@ijjk
Copy link
Member

ijjk commented May 11, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js script-loader Change
buildDuration 15.8s 16.5s ⚠️ +688ms
buildDurationCached 5.1s 4.9s -221ms
nodeModulesSize 46.5 MB 46.5 MB -1.61 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary janicklas-ralph/next.js script-loader Change
/ failed reqs 0 0
/ total time (seconds) 2.699 2.77 ⚠️ +0.07
/ avg req/sec 926.11 902.63 ⚠️ -23.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.503 1.722 ⚠️ +0.22
/error-in-render avg req/sec 1662.91 1451.64 ⚠️ -211.27
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js script-loader Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js script-loader Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js script-loader Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js script-loader Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js script-loader Change
index.html gzip 560 B 560 B
link.html gzip 568 B 568 B
withRouter.html gzip 556 B 556 B
Overall change 1.68 kB 1.68 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js script-loader Change
buildDuration 19.9s 20.1s ⚠️ +176ms
buildDurationCached 7.3s 7.4s ⚠️ +123ms
nodeModulesSize 46.5 MB 46.5 MB -1.61 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js script-loader Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js script-loader Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js script-loader Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js script-loader Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Serverless bundles Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js script-loader Change
_error.js 1.34 MB 1.34 MB -503 B
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 1.34 MB 1.34 MB -503 B
link.js 1.4 MB 1.4 MB -503 B
routerDirect.js 1.39 MB 1.39 MB -503 B
withRouter.js 1.39 MB 1.39 MB -503 B
Overall change 6.9 MB 6.9 MB -2.52 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary janicklas-ralph/next.js script-loader Change
buildDuration 13.4s 13.6s ⚠️ +122ms
buildDurationCached 5.8s 5.7s -99ms
nodeModulesSize 46.5 MB 46.5 MB -1.61 kB
Page Load Tests Overall increase ✓
vercel/next.js canary janicklas-ralph/next.js script-loader Change
/ failed reqs 0 0
/ total time (seconds) 2.865 2.815 -0.05
/ avg req/sec 872.66 888.03 +15.37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.665 1.555 -0.11
/error-in-render avg req/sec 1501.91 1607.25 +105.34
Client Bundles (main, webpack, commons)
vercel/next.js canary janicklas-ralph/next.js script-loader Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.19 kB 7.19 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary janicklas-ralph/next.js script-loader Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary janicklas-ralph/next.js script-loader Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.72 kB 3.72 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
21c68fa65a48..217.css gzip 125 B 125 B
Overall change 9.37 kB 9.37 kB
Client Build Manifests
vercel/next.js canary janicklas-ralph/next.js script-loader Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary janicklas-ralph/next.js script-loader Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: 02cbf54

@timneutkens timneutkens merged commit b859c5b into vercel:canary May 12, 2021
@janicklas-ralph janicklas-ralph deleted the script-loader branch May 25, 2021 06:10
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants