Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental note for has routes #24529

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Remove experimental note for has routes #24529

merged 3 commits into from
Apr 28, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 27, 2021

This removes the warnings/notes for the has custom-routes feature being experimental

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk marked this pull request as draft April 27, 2021 17:37
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Apr 27, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/experimental-has Change
buildDuration 15.1s 16.3s ⚠️ +1.2s
buildDurationCached 5.1s 4.6s -487ms
nodeModulesSize 46.7 MB 46.6 MB -749 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/experimental-has Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.661 2.89 ⚠️ +0.23
/ avg req/sec 939.54 864.99 ⚠️ -74.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.597 1.782 ⚠️ +0.19
/error-in-render avg req/sec 1565.85 1402.54 ⚠️ -163.31
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/experimental-has Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/experimental-has Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/experimental-has Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/experimental-has Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/experimental-has Change
index.html gzip 611 B 611 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/experimental-has Change
buildDuration 18.9s 19.2s ⚠️ +289ms
buildDurationCached 7.5s 7s -551ms
nodeModulesSize 46.7 MB 46.6 MB -749 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/experimental-has Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/experimental-has Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/experimental-has Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/experimental-has Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js update/experimental-has Change
_error.js 1.39 MB 1.39 MB -281 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -281 B
link.js 1.45 MB 1.45 MB -279 B
routerDirect.js 1.44 MB 1.44 MB -281 B
withRouter.js 1.44 MB 1.44 MB -281 B
Overall change 7.14 MB 7.14 MB -1.4 kB
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/experimental-has Change
buildDuration 13.6s 13.1s -541ms
buildDurationCached 5.4s 5.7s ⚠️ +332ms
nodeModulesSize 46.7 MB 46.6 MB -749 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/experimental-has Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.841 2.624 -0.22
/ avg req/sec 880.01 952.79 +72.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.651 1.494 -0.16
/error-in-render avg req/sec 1514.41 1672.91 +158.5
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/experimental-has Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/experimental-has Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/experimental-has Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/experimental-has Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/experimental-has Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: e857257

leerob
leerob approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, waiting on final approval!

@timneutkens timneutkens marked this pull request as ready for review April 28, 2021 09:03
@kodiakhq kodiakhq bot merged commit f3d5183 into vercel:canary Apr 28, 2021
This was referenced Apr 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
This was referenced Apr 28, 2021
Open
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @timneutkens @leerob