Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump styled-components lib version examples #24482

Merged
merged 5 commits into from
Apr 27, 2021
Merged

feat: bump styled-components lib version examples #24482

merged 5 commits into from
Apr 27, 2021
+20 −18

Conversation

omariosouto
Copy link
Contributor

@omariosouto omariosouto commented Apr 26, 2021 •
edited
Loading

Hi folks I know many people that use that example and it could be using the new version of React to be according with the NextJS v11

Documentation / Examples

  • Make sure the linting passes
  • Make sure that the bumped up versions are okay

@ijjk ijjk added the examples Issue/PR related to examples label Apr 26, 2021
leerob
leerob reviewed Apr 27, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is react-is needed?

@omariosouto
Copy link
Contributor Author

@leerob I just follow the FAQ from the migration guide: https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v5

In a project that I've been working on it was necessary and already was present in other examples

@omariosouto omariosouto requested a review from leerob April 27, 2021 13:34
@kodiakhq kodiakhq bot merged commit 5de5e49 into vercel:canary Apr 27, 2021
This was referenced Apr 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 28, 2021
Open
Open
Merged
Open
Open
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob leerob approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omariosouto @leerob @ijjk