Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all modules are included in the stats file #21942

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Make sure all modules are included in the stats file #21942

merged 2 commits into from
Feb 7, 2021

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 7, 2021 •
edited
Loading

Also ensures reasons is added

@ijjk ijjk added the type: next label Feb 7, 2021
@ijjk
Copy link
Member

ijjk commented Feb 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
buildDuration 10.2s 10.3s ⚠️ +107ms
nodeModulesSize 75.3 MB 75.3 MB -75 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.152 2.206 ⚠️ +0.05
/ avg req/sec 1161.85 1133.24 ⚠️ -28.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.432 1.524 ⚠️ +0.09
/error-in-render avg req/sec 1746.29 1639.93 ⚠️ -106.36
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
buildDuration 12.2s 12.2s -57ms
nodeModulesSize 75.3 MB 75.3 MB -75 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
buildDuration 12.8s 12.9s ⚠️ +125ms
nodeModulesSize 75.3 MB 75.3 MB -75 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.132 2.182 ⚠️ +0.05
/ avg req/sec 1172.73 1145.84 ⚠️ -26.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.556 1.51 -0.05
/error-in-render avg req/sec 1606.52 1655.47 +48.95
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "02Y4wAByWI5aBAhDjJM4r",
+        "buildId": "9ei_oknav9G0bW5mwruAs",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/02Y4wAByWI5aBAhDjJM4r/_buildManifest.js"
+      src="/_next/static/9ei_oknav9G0bW5mwruAs/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/02Y4wAByWI5aBAhDjJM4r/_ssgManifest.js"
+      src="/_next/static/9ei_oknav9G0bW5mwruAs/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "02Y4wAByWI5aBAhDjJM4r",
+        "buildId": "9ei_oknav9G0bW5mwruAs",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/02Y4wAByWI5aBAhDjJM4r/_buildManifest.js"
+      src="/_next/static/9ei_oknav9G0bW5mwruAs/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/02Y4wAByWI5aBAhDjJM4r/_ssgManifest.js"
+      src="/_next/static/9ei_oknav9G0bW5mwruAs/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "02Y4wAByWI5aBAhDjJM4r",
+        "buildId": "9ei_oknav9G0bW5mwruAs",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/02Y4wAByWI5aBAhDjJM4r/_buildManifest.js"
+      src="/_next/static/9ei_oknav9G0bW5mwruAs/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/02Y4wAByWI5aBAhDjJM4r/_ssgManifest.js"
+      src="/_next/static/9ei_oknav9G0bW5mwruAs/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 5693872

@ijjk
Copy link
Member

ijjk commented Feb 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
buildDuration 11.6s 11.7s ⚠️ +144ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +34 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.465 2.461 0
/ avg req/sec 1014.17 1015.7 +1.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.653 1.69 ⚠️ +0.04
/error-in-render avg req/sec 1512.09 1479.71 ⚠️ -32.38
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
buildDuration 13.6s 13.9s ⚠️ +325ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +34 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
buildDuration 14.1s 14.4s ⚠️ +328ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +34 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.409 2.371 -0.04
/ avg req/sec 1037.63 1054.48 +16.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.701 1.675 -0.03
/error-in-render avg req/sec 1469.83 1492.49 +22.66
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/stats-modules Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "ECI7Yc8saiNh7C_Bn8-Nn",
+        "buildId": "ENAt__0pC5pP4-Qe8xZP5",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ECI7Yc8saiNh7C_Bn8-Nn/_buildManifest.js"
+      src="/_next/static/ENAt__0pC5pP4-Qe8xZP5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ECI7Yc8saiNh7C_Bn8-Nn/_ssgManifest.js"
+      src="/_next/static/ENAt__0pC5pP4-Qe8xZP5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "ECI7Yc8saiNh7C_Bn8-Nn",
+        "buildId": "ENAt__0pC5pP4-Qe8xZP5",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ECI7Yc8saiNh7C_Bn8-Nn/_buildManifest.js"
+      src="/_next/static/ENAt__0pC5pP4-Qe8xZP5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ECI7Yc8saiNh7C_Bn8-Nn/_ssgManifest.js"
+      src="/_next/static/ENAt__0pC5pP4-Qe8xZP5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "ECI7Yc8saiNh7C_Bn8-Nn",
+        "buildId": "ENAt__0pC5pP4-Qe8xZP5",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ECI7Yc8saiNh7C_Bn8-Nn/_buildManifest.js"
+      src="/_next/static/ENAt__0pC5pP4-Qe8xZP5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ECI7Yc8saiNh7C_Bn8-Nn/_ssgManifest.js"
+      src="/_next/static/ENAt__0pC5pP4-Qe8xZP5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: a4f4e8f

@timneutkens timneutkens merged commit 44fa86e into vercel:canary Feb 7, 2021
@timneutkens timneutkens deleted the fix/stats-modules branch February 7, 2021 19:06
This was referenced Feb 16, 2021
Open
Open
Open
This was referenced Apr 12, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 18, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timneutkens @ijjk