Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppressing eslint warning #21163

Merged
merged 1 commit into from
Jan 26, 2021
Merged

suppressing eslint warning #21163

merged 1 commit into from
Jan 26, 2021

Conversation

kaznak
Copy link
Contributor

@kaznak kaznak commented Jan 15, 2021

I wrote a patch for the issue #21162.

Fixes #21162

@ijjk ijjk added the examples Issue/PR related to examples label Jan 15, 2021
@ijjk
Copy link
Member

ijjk commented Jan 15, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
buildDuration 9.7s 9.8s ⚠️ +182ms
nodeModulesSize 77.5 MB 77.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
/ failed reqs 0 0
/ total time (seconds) 1.895 1.933 ⚠️ +0.04
/ avg req/sec 1319.49 1293.08 ⚠️ -26.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.178 1.224 ⚠️ +0.05
/error-in-render avg req/sec 2121.87 2042.38 ⚠️ -79.49
Client Bundles (main, webpack, commons)
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-b70be25..6967.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
buildDuration 11.4s 11.4s -10ms
nodeModulesSize 77.5 MB 77.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-b70be25..6967.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary kaznak/next.js fix.example_with-eslint-jest Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 7ce037f

@Timer Timer merged commit 07d4af9 into vercel:canary Jan 26, 2021
@kaznak kaznak deleted the fix.example_with-eslint-jest branch January 29, 2021 08:58
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eslint warning in the starting repository generated by the with-typescript-eslint-jest example
4 participants