-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal dep upgrade - avoid alpha/beta, use the latest minor #20411
Conversation
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.977 | 2.037 | |
/ avg req/sec | 1264.67 | 1227.21 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.227 | 1.261 | |
/error-in-render avg req/sec | 2037.1 | 1982.59 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
677f882d2ed8..5e70.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-e0d2962..b163.js gzip | 6.56 kB | 6.56 kB | ✓ |
webpack-95c2..e870.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
polyfills-d3..23f6.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_app-0d19cb6..5497.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-85785..a9f3.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-42456f..0c06.js gzip | 887 B | 887 B | ✓ |
index-8081ce..e44f.js gzip | 227 B | 227 B | ✓ |
link-0ab9f83..fa00.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..c3d8.js gzip | 303 B | 303 B | ✓ |
withRouter-0..a68e.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.05 kB | 8.05 kB | ✓ |
Client Build Manifests
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
index.html gzip | 612 B | 612 B | ✓ |
link.html gzip | 620 B | 620 B | ✓ |
withRouter.html gzip | 607 B | 607 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
buildDuration | 12.6s | 12.2s | -411ms |
nodeModulesSize | 82.6 MB | 82.6 MB | -38 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
677f882d2ed8..5e70.js gzip | 12.8 kB | 12.8 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-e0d2962..b163.js gzip | 6.56 kB | 6.56 kB | ✓ |
webpack-95c2..e870.js gzip | 751 B | 751 B | ✓ |
Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
polyfills-d3..23f6.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_app-0d19cb6..5497.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-85785..a9f3.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-42456f..0c06.js gzip | 887 B | 887 B | ✓ |
index-8081ce..e44f.js gzip | 227 B | 227 B | ✓ |
link-0ab9f83..fa00.js gzip | 1.61 kB | 1.61 kB | ✓ |
routerDirect..c3d8.js gzip | 303 B | 303 B | ✓ |
withRouter-0..a68e.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.05 kB | 8.05 kB | ✓ |
Client Build Manifests
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
Overall change | 323 B | 323 B | ✓ |
Serverless bundles
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.16 MB | 5.16 MB | ✓ |
Failing test suitesCommit: f4cade9 test/integration/amphtml-fragment-style/test/index.test.js
Expand output● AMP Fragment Styles › adds styles from fragment in AMP mode correctly
● Test suite failed to run
test/integration/amphtml-custom-optimizer/test/index.test.js
Expand output● AMP Custom Optimizer › should build and start for static page
● AMP Custom Optimizer › should build and start for dynamic page
test/integration/amphtml-custom-validator/test/index.test.js
Expand output● AMP Custom Validator › should build and start successfully
● AMP Custom Validator › should run in dev mode successfully
test/integration/amp-export-validation/test/index.test.js
Expand output● AMP Validation on Export › should have shown errors during build
● AMP Validation on Export › should export AMP pages
● AMP Validation on Export › shows AMP warning without throwing error
● AMP Validation on Export › throws error on AMP error
● AMP Validation on Export › shows warning and error when throwing error
test/integration/auto-export-query-error/test/index.test.js
Expand output● Auto Export › server mode › should show warning for query provided for auto exported page correctly
● Auto Export › serverless mode › should show warning for query provided for auto exported page correctly
test/integration/export/test/index.test.js
Expand output● Static Export › should delete existing exported files
● Static Export › should honor exportTrailingSlash for 404 page
● Static Export › should handle trailing slash in getStaticPaths
● Static Export › should only output 404.html without exportTrailingSlash
● Static Export › should not duplicate /index with exportTrailingSlash
● Static Export › Render via SSR › should render the home page
● Static Export › Render via SSR › should render the about page
● Static Export › Render via SSR › should render links correctly
● Static Export › Render via SSR › should render a page with getInitialProps
● Static Export › Render via SSR › should render a dynamically rendered custom url page
● Static Export › Render via SSR › should render pages with dynamic imports
● Static Export › Render via SSR › should render paths with extensions
● Static Export › Render via SSR › should give empty object for query if there is no query
● Static Export › Render via SSR › should render _error on 404.html even if not provided in exportPathMap
● Static Export › Render via SSR › should render _error on /404/index.html
● Static Export › Render via SSR › Should serve static files
● Static Export › Render via SSR › Should serve public files
● Static Export › Render via SSR › Should render dynamic files with query
● Static Export › Render via browser › should render the home page
● Static Export › Render via browser › should add trailing slash on Link
● Static Export › Render via browser › should not add any slash on hash Link
● Static Export › Render via browser › should preserve hash symbol on empty hash Link
● Static Export › Render via browser › should preserve question mark on empty query Link
● Static Export › Render via browser › should not add trailing slash on Link when disabled
● Static Export › Render via browser › should do navigations via Link
● Static Export › Render via browser › should do navigations via Router
● Static Export › Render via browser › should do run client side javascript
● Static Export › Render via browser › should render pages using getInitialProps
● Static Export › Render via browser › should render dynamic pages with custom urls
● Static Export › Render via browser › should support client side naviagtion
● Static Export › Render via browser › should render dynamic import components in the client
● Static Export › Render via browser › should render pages with url hash correctly
● Static Export › Render via browser › should navigate even if used a button inside
● Static Export › Render via browser › should update query after mount
● Static Export › Render via browser › pages in the nested level: level1 › should render the home page
● Static Export › Render via browser › pages in the nested level: level1 › should render the about page
● Static Export › Render in development mode › should render the home page
● Static Export › Render in development mode › should render pages only existent in exportPathMap page
● Static Export › ExportPathMap's query in development mode › should be present in ctx.query
● Static Export › ExportPathMap's query in development mode › should replace url query params in ctx.query when conflicting
● Static Export › ExportPathMap's query in development mode › should be merged with url query params in ctx.query
● Static Export › Dynamic routes export › Should throw error not matched route
● Static Export › API routes export › Should throw if a route is matched
● Test suite failed to run
|
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
buildDuration | 8.5s | 8.4s | -93ms |
nodeModulesSize | 77.6 MB | 77.8 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.683 | 1.666 | -0.02 |
/ avg req/sec | 1485.2 | 1500.43 | +15.23 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.15 | 1.039 | -0.11 |
/error-in-render avg req/sec | 2174.37 | 2406.87 | +232.5 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
677f882d2ed8..43e3.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-9e3e4e6..2023.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
polyfills-af..9390.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 621 B | 621 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
buildDuration | 9.9s | 9.6s | -253ms |
nodeModulesSize | 77.6 MB | 77.8 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
677f882d2ed8..43e3.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-9e3e4e6..2023.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
polyfills-af..9390.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.18 MB | 5.18 MB | ✓ |
Webpack 5 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
buildDuration | 10.1s | 10.5s | |
nodeModulesSize | 77.6 MB | 77.8 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.69 | 1.666 | -0.02 |
/ avg req/sec | 1479.38 | 1500.79 | +21.41 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.047 | 1.033 | -0.01 |
/error-in-render avg req/sec | 2387.27 | 2420.26 | +32.99 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
597-3bd7d6bd..868b.js gzip | 13 kB | 13 kB | ✓ |
778-d412f8e7..3ee1.js gzip | 6.56 kB | 6.56 kB | ✓ |
838-adcbad39..6e83.js gzip | 31.1 kB | 31.1 kB | ✓ |
framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-6a6a792..6877.js gzip | 96 B | 96 B | ✓ |
webpack-e302..54e9.js gzip | 954 B | 954 B | ✓ |
Overall change | 91 kB | 91 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
polyfills-a0..538c.js gzip | 88 B | 88 B | ✓ |
Overall change | 88 B | 88 B | ✓ |
Client Pages
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_app-a5b2e84..33cf.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error-6f1f9..5577.js gzip | 3.38 kB | 3.38 kB | ✓ |
hooks-725de8..0a15.js gzip | 904 B | 904 B | ✓ |
index-939503..6e1c.js gzip | 232 B | 232 B | ✓ |
link-e0cc871..fdbb.js gzip | 1.63 kB | 1.63 kB | ✓ |
routerDirect..9360.js gzip | 308 B | 308 B | ✓ |
withRouter-6..44ec.js gzip | 304 B | 304 B | ✓ |
Overall change | 8.02 kB | 8.02 kB | ✓ |
Client Build Manifests
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
_buildManifest.js gzip | 299 B | 299 B | ✓ |
Overall change | 299 B | 299 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | chulkilee/next.js dep-upgrade-minimal | Change | |
---|---|---|---|
index.html gzip | 585 B | 585 B | ✓ |
link.html gzip | 592 B | 592 B | ✓ |
withRouter.html gzip | 581 B | 581 B | ✓ |
Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "LdsUt9VGnfSFoS4lAgwON",
+ "buildId": "lS4B0j-pAfLzAhhA1ZRz9",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_buildManifest.js"
+ src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_ssgManifest.js"
+ src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_ssgManifest.js"
async=""
></script>
</body>
Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "LdsUt9VGnfSFoS4lAgwON",
+ "buildId": "lS4B0j-pAfLzAhhA1ZRz9",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_buildManifest.js"
+ src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_ssgManifest.js"
+ src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_ssgManifest.js"
async=""
></script>
</body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "LdsUt9VGnfSFoS4lAgwON",
+ "buildId": "lS4B0j-pAfLzAhhA1ZRz9",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_buildManifest.js"
+ src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/LdsUt9VGnfSFoS4lAgwON/_ssgManifest.js"
+ src="/_next/static/lS4B0j-pAfLzAhhA1ZRz9/_ssgManifest.js"
async=""
></script>
</body>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! It seems like the tests, and CI are failing unfortunately but I can't help...
I mostly interested in styled-jsx
update.
Going to close this as it's stale, feel free to open a new PR and I'll review it! |
(see links for changelog / releases)
I ran
yarn && ./check-pre-compiled.sh
after updating deps. Let me know if I need to something else!