Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial example for i18n routing #18206

Merged
merged 18 commits into from
Oct 27, 2020
Merged

Add initial example for i18n routing #18206

merged 18 commits into from
Oct 27, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 24, 2020

This is a follow-up to #18067 adding an example for i18n routing

x-ref: #17370

ijjk and others added 15 commits October 20, 2020 16:06
@ijjk
Add initial i18n documentation
c220da6
@ijjk
Merge remote-tracking branch 'upstream/canary' into docs/i18n
70d1617
@ijjk @timneutkens
Apply suggestions from code review
05c0ffe 
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
@ijjk @leerob
Apply suggestions from code review
85f2728 
Co-authored-by: Lee Robinson <me@leerob.io>
@ijjk
Apply more suggestions
ba0247c
@ijjk
rephrase a bit more
43d53f5
@ijjk
Merge remote-tracking branch 'upstream/canary' into docs/i18n
5fd6a11
@ijjk
Merge remote-tracking branch 'upstream/canary' into docs/i18n
d554ed5
@ijjk
Add initial example files
0025388
@timneutkens
Update doc
053d2a9
@kodiakhq
Merge branch 'canary' into docs/i18n
9390744
@ijjk
Merge branch 'docs/i18n' of github.com:ijjk/next.js into docs/i18n
f2d39e2
@ijjk
Merge remote-tracking branch 'upstream/canary' into docs/i18n
59ab380
@ijjk
Merge remote-tracking branch 'upstream/canary' into example/i18n
31cc439
@ijjk
Add example pages for i18n routing
6f30287
@ijjk ijjk added the examples Issue/PR related to examples label Oct 24, 2020
@ijjk ijjk mentioned this pull request Oct 24, 2020
Merged
@ijjk ijjk requested a review from timneutkens October 24, 2020 19:03
@ijjk
Copy link
Member Author

ijjk commented Oct 24, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js example/i18n Change
buildDuration 12.9s 12.8s -54ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js example/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.4 2.357 -0.04
/ avg req/sec 1041.63 1060.46 +18.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.315 1.276 -0.04
/error-in-render avg req/sec 1901.13 1958.52 +57.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-af76201..828d.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3ba933e..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js example/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js example/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js example/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js example/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js example/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js example/i18n Change
buildDuration 14.7s 14.2s -427ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-af76201..828d.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-3ba933e..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js example/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js example/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js example/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js example/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js example/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.42 MB 5.42 MB ✓
Commit: 6f30287

@ijjk ijjk marked this pull request as ready for review October 27, 2020 06:21
Timer
Timer requested changes Oct 27, 2020
View reviewed changes
examples/i18n-routing/next.config.js Outdated Show resolved Hide resolved
examples/i18n-routing/package.json Outdated Show resolved Hide resolved
@ijjk ijjk requested a review from Timer October 27, 2020 06:51
@ijjk
Copy link
Member Author

ijjk commented Oct 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js example/i18n Change
buildDuration 13.1s 13.2s ⚠️ +95ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js example/i18n Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.501 2.445 -0.06
/ avg req/sec 999.61 1022.55 +22.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.332 1.383 ⚠️ +0.05
/error-in-render avg req/sec 1876.52 1808.12 ⚠️ -68.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js example/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js example/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js example/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js example/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js example/i18n Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary ijjk/next.js example/i18n Change
buildDuration 15.2s 15.2s ⚠️ +39ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..d3ae.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js example/i18n Change
677f882d2ed8..dule.js gzip 7.01 kB 7.01 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js example/i18n Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js example/i18n Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js example/i18n Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js example/i18n Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js example/i18n Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.11 MB 1.11 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.43 MB 5.43 MB ✓
Commit: 94bbcc2

This was referenced Sep 17, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 12, 2022
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 23, 2022
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@chibicode chibicode Awaiting requested review from chibicode

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @Timer @timneutkens