Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include all files in Prettier #17050

Merged
merged 5 commits into from
Sep 14, 2020
Merged

Include all files in Prettier #17050

merged 5 commits into from
Sep 14, 2020

Conversation

jensmeindertsma
Copy link

@jensmeindertsma jensmeindertsma commented Sep 12, 2020 •
edited
Loading

This uses the "Expand directories" feature introduces in Prettier 2.0 to automatically format all supported file types.

Also, I fixed some badly formatted files.

@ijjk ijjk added the examples Issue/PR related to examples label Sep 12, 2020
@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
buildDuration 14.9s 14.7s -189ms
nodeModulesSize 60 MB 60 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.681 2.675 -0.01
/ avg req/sec 932.58 934.6 +2.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.719 1.624 -0.09
/error-in-render avg req/sec 1454.45 1539.82 +85.37
Client Bundles (main, webpack, commons)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
buildDuration 17.2s 16.7s -497ms
nodeModulesSize 60 MB 60 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 1f121e9

@jensmeindertsma jensmeindertsma changed the title Clean up Prettier script Fix bad code formatting Sep 12, 2020
@jensmeindertsma
Copy link
Author

Somehow the whitespace in readme.md causes a ton of test failures. After a revert things seem to work fine.

@ijjk
Copy link
Member

ijjk commented Sep 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
buildDuration 12.2s 12.1s -57ms
nodeModulesSize 60 MB 60 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.213 2.274 ⚠️ +0.06
/ avg req/sec 1129.72 1099.49 ⚠️ -30.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.407 1.355 -0.05
/error-in-render avg req/sec 1776.87 1845.68 +68.81
Client Bundles (main, webpack, commons)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
buildDuration 14s 13.6s -434ms
nodeModulesSize 60 MB 60 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 1514455

@Timer Timer changed the title Fix bad code formatting Include all files in Prettier Sep 14, 2020
Timer
Timer approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Sep 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
buildDuration 12.5s 12.5s -35ms
nodeModulesSize 60 MB 60 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.263 2.349 ⚠️ +0.09
/ avg req/sec 1104.91 1064.35 ⚠️ -40.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.329 1.424 ⚠️ +0.09
/error-in-render avg req/sec 1880.45 1755.93 ⚠️ -124.52
Client Bundles (main, webpack, commons)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
buildDuration 13.8s 13.9s ⚠️ +108ms
nodeModulesSize 60 MB 60 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3d83558..e210.js gzip 7.02 kB 7.02 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0a101e0..dule.js gzip 6.09 kB 6.09 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary jensmeindertsma/next.js clean-up-scripts Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: d61a8e1

@kodiakhq kodiakhq bot merged commit a3c4772 into vercel:canary Sep 14, 2020
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
Include all files in Prettier (vercel#17050)
ff4e275 
This uses the "Expand directories" feature introduces in Prettier 2.0 to automatically format all supported file types.

Also, I fixed some badly formatted files.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jensmeindertsma @ijjk @Timer