Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove false positive in circular structure detection #16380

Merged
merged 8 commits into from
Sep 12, 2020
Merged

Remove false positive in circular structure detection #16380

merged 8 commits into from
Sep 12, 2020

Commits on Aug 20, 2020

  1. Prevent interpreting an array which has the same object multiple time… 

    …s as a circular structure

This prevents interpreting an array which has the same object multiple times as a circular structure by only checking one of these identical objects.
Increases computational complexity quite a bit though, but if this is only used in dev mode it might be fine.
    @m-lautenbach
    m-lautenbach committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    611066c View commit details
    Browse the repository at this point in the history

  2. Add test

    Markus Lautenbach committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    15de835 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'canary' into patch-1

    @m-lautenbach
    m-lautenbach committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    a8676c5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'canary' into patch-1

    @m-lautenbach
    m-lautenbach committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    d0c0f9c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Merge branch 'canary' into patch-1

    @Timer
    Timer committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    ebaa404 View commit details
    Browse the repository at this point in the history

  2. Only check unique values in array

    @Timer
    Timer committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    2eac3de View commit details
    Browse the repository at this point in the history

  3. Keep track of checked values

    @Timer
    Timer committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    ae7cc20 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'canary' into patch-1

    @kodiakhq
    kodiakhq[bot] committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    12f9fff View commit details
    Browse the repository at this point in the history