with-i18next example #1496
Merged
with-i18next example #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 24, 2017 16:22
| export async function getTranslation (lang, file, baseUrl) { | ||
| const response = await fetch(`${baseUrl}${lang}/${file}.json`) | ||
| const json = await response.json() | ||
| let translations = {} |
There was a problem hiding this comment.
how about:
return {
[lang]: {
[file]: json
}
}There was a problem hiding this comment.
much better, updating the code now
| @@ -0,0 +1,14 @@ | |||
| import i18n from 'i18next' | |||
|
|
|||
| const startI18n = file => { | |||
There was a problem hiding this comment.
const startI18n = file => i18n.init({
fallbackLng: 'pt',
resources: file,
ns: ['common'],
defaultNS: 'common',
debug: false
})
examples/with-i18next/pages/index.js
Outdated
| const isServer = !!req | ||
| const translations = await getTranslation('pt', 'common', 'http://localhost:3000/static/locales/') | ||
|
|
||
| return { isServer, translations } |
There was a problem hiding this comment.
Are we using the isServer prop?
There was a problem hiding this comment.
not really. My bad.
Lingering code from some previous tests...
examples/with-i18next/pages/index.js
Outdated
| export default class Homepage extends Component { | ||
| static async getInitialProps ({ req }) { | ||
| const isServer = !!req | ||
| const translations = await getTranslation('pt', 'common', 'http://localhost:3000/static/locales/') |
There was a problem hiding this comment.
Do we need to express the full url? What happens if we deploy to a non localhost env? for example we suggest you can use zeit to deploy
There was a problem hiding this comment.
for the server-side the polyfill requires it to be an absolute url. I couldn't figure a way of going around that. That's why url is a parameter. I'm fully open to suggestions though...
timneutkens
approved these changes
Apr 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this example shows (what I believe to be) the simplest configuration to use i18next with NextJS