Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Mention the new data fetching methods on missing places #11620

Merged
merged 2 commits into from
Apr 6, 2020
Merged

[docs] Mention the new data fetching methods on missing places #11620

merged 2 commits into from
Apr 6, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 2, 2020

Read the changes for more details.

@lfades lfades requested a review from Timer as a code owner April 2, 2020 23:38
@ijjk
Copy link
Member

ijjk commented Apr 2, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
buildDuration 10.5s 10.9s ⚠️ +349ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5272.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.75 kB 6.75 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
index.html gzip 917 B 917 B ✓
link.html gzip 926 B 926 B ✓
withRouter.html gzip 915 B 915 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
buildDuration 11.1s 11s -146ms
nodeModulesSize 47.7 MB 47.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5272.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.75 kB 6.75 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary lfades/next.js docs/update-ssr-mentions Change
_error.js gzip 233 kB 232 kB -454 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 232 kB 233 kB ⚠️ +301 B
link.js gzip 243 kB 243 kB -90 B
routerDirect.js gzip 241 kB 241 kB -41 B
withRouter.js gzip 241 kB 241 kB ✓
Overall change 1.19 MB 1.19 MB -284 B

@lfades lfades requested a review from chibicode April 3, 2020 19:48
@timneutkens timneutkens merged commit f33ba2c into vercel:canary Apr 6, 2020
This was referenced Apr 17, 2020
Merged
Merged
Closed
This was referenced Dec 29, 2020
Open
Open
@Jcrowell74 Jcrowell74 mentioned this pull request Mar 14, 2021
Open
@blubfoo blubfoo mentioned this pull request Mar 15, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@Timer Timer Awaiting requested review from Timer

@chibicode chibicode Awaiting requested review from chibicode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfades @ijjk @timneutkens