Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated api-routes-graphql to use getStaticProps #11581

Closed
wants to merge 1 commit into from

Conversation

djanda97
Copy link
Contributor

@djanda97 djanda97 commented Apr 2, 2020

Related to #11014.

@ijjk
Copy link
Member

ijjk commented Apr 2, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
buildDuration 10.9s 11s ⚠️ +118ms
nodeModulesSize 47.7 MB 47.7 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
index.html gzip 918 B 918 B
link.html gzip 926 B 926 B
withRouter.html gzip 916 B 916 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
buildDuration 11.5s 11.7s ⚠️ +125ms
nodeModulesSize 47.7 MB 47.7 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary djanda97/next.js ssg-api-routes-graphql Change
_error.js gzip 233 kB 232 kB -442 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 959 B 959 B
index.js gzip 232 kB 232 kB -47 B
link.js gzip 242 kB 243 kB ⚠️ +144 B
routerDirect.js gzip 241 kB 241 kB -9 B
withRouter.js gzip 241 kB 241 kB -4 B
Overall change 1.19 MB 1.19 MB -358 B

@lfades
Copy link
Member

lfades commented Apr 2, 2020

Closing on favor of #11383 - The example in this PR will fail if you run next build because localhost is not available at build time for getStaticProps

@lfades lfades closed this Apr 2, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants