Don't delete .next folder before a replacement is built
#1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant. Atomicity ftw |
rauchg
reviewed
Feb 14, 2017
| *.sublime-* |
There was a problem hiding this comment.
missed this. I don't think we should have an editors section. gitignore is for artifacts of the project itself, not user systems
There was a problem hiding this comment.
Missed it myself, sorry. But I don't think I added that line? Must have been EOL.
|
Thanks, @rauchg! |
|
I think the build folder should be created in temp dir otherwise it remains when build failed. |
|
Not sure that's a bad thing because people can check for exit code and
clean up if necessary ?
On Tue, Feb 14, 2017 at 8:36 PM Naoyuki Kanezawa ***@***.***> wrote:
I think the build folder should be created in temp dir otherwise it
remains when build failed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1139 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAy8SZAxLy9Tvf-JiMm6jdQe8GW2HHeks5rcjpqgaJpZM4MBG6A>
.
|
|
I dont know when you want to keep failed |
|
"Post-mortem" analysis of the failed build perhaps
On Tue, Feb 14, 2017 at 8:42 PM Naoyuki Kanezawa ***@***.***> wrote:
I dont know when you want to keep failed .next-xxx on your app folder.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1139 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAy8QEWdBoQ8_ZhjV8HE8WX-CmAmsPQks5rcjv0gaJpZM4MBG6A>
.
|
|
Possibly. though I think we can print the path when failed instead since you have no idea what |
|
Good point. Let's print path if it fails
On Tue, Feb 14, 2017 at 8:53 PM Naoyuki Kanezawa ***@***.***> wrote:
Possibly, though I think we can print the path when failed instead since
you have no idea what .next-xxx is anyway. I just want to make sure it
doesnt remain when I cancelled the build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1139 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAy8T_qlmRL5FK9LpVynnZjkEXwoRp1ks5rcj5ogaJpZM4MBG6A>
.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1135.
On build, sequentially:
.nextas is.next-6c15581c-e852-....nextto a random.next-5c523d99-4375-....next-6c15581c-e852-...to.next, efficiently replacing the current state.next-5c523d99-4375-...next.jsprocess)On deploy (using eg.
pm2), this led my current app to have, a total down time of virtually nothing, instead of being down for several minutes.The problem was, in the current state of
next.js, that the entire.nextdirectory suddenly disappeared when mynext.jsprocess was still running and using the files in it, which made it crash and displayInternal Server Error(the_error.jsdisappeared, too...).With this solution, there's virtually no down time when deploying.