data-testid being stripped in test/local env in latest 12.1.6

[wadehammes]

Verify canary release

• I verified that the issue exists in Next.js canary release

Provide environment information

Operating System:
Platform: linux
Arch: x64
Version: #1 SMP Wed Mar 2 00:30:59 UTC 2022
Binaries:
Node: 14.18.1
npm: 6.14.15
Yarn: 1.22.18
pnpm: N/A
Relevant packages:
next: 12.1.6
react: 18.1.0
react-dom: 18.1.0

What browser are you using? (if relevant)

Firefox

How are you deploying your application? (if relevant)

Vercel

Describe the Bug

In the latest 12.1.6, running Jest locally with tests that try to locate elements using the data-testid attr fail, this works fine in 12.1.5.

In my next config I have:

compiler: {
    styledComponents: true,
    reactRemoveProperties: true,
  },

Expected Behavior

data-testid should only be removed in production env, not local or preview envs.

To Reproduce

Create a projec with latest next, jest, and a test that looks for a data-testid.

[wadehammes]

Maybe related to the issues being experienced in #36647

[wadehammes]

Confirmed it fails in 12.1.6-canary.15, all canaries before work fine.

[timneutkens]

This is because next/jest previously did not apply the opt-in transforms and that was fixed. I guess for reactRemoveProperties we'll want to disable that in the test env when the true option is used.

[azeez1776]

Hey @timneutkens, can I work on the issue? should I change the reactRemoveProperties in the test/integration/telemetry/next.config.swc directory, I'm really new and would like to contrribute.

[SukkaW]

The issue should be fixed by #36922

In the meantime, you can apply a temporary fix in your next.config.js:

// next.config.js
module.exports = {
  compiler: {
-   reactRemoveProperties: true
+   reactRemoveProperties: process.env.NODE_ENV === 'production'
  }
}

[github-actions]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.