Ensure next-server prepare only execute once

vercel · Aug 7, 2024 · b2f14a1 · b2f14a1
1 parent 070159a
commit b2f14a1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/test/e2e/instrumentation-hook/register-once/instrumentation.js b/test/e2e/instrumentation-hook/register-once/instrumentation.js
@@ -1,5 +1,11 @@
+let count = 0
+
 export function register() {
   if (process.env.NEXT_RUNTIME === 'nodejs') {
+    if (count > 0) {
+      throw new Error('duplicated-register')
+    }
     console.log('register-log')
+    count++
   }
 }
diff --git a/test/e2e/instrumentation-hook/register-once/register-once.test.ts b/test/e2e/instrumentation-hook/register-once/register-once.test.ts
@@ -3,7 +3,6 @@ import { nextTestSetup } from 'e2e-utils'
 describe('instrumentation-hook - register-once', () => {
   const { next, skipped } = nextTestSetup({
     files: __dirname,
-    skipDeployment: true,
   })
 
   if (skipped) {
@@ -14,4 +13,10 @@ describe('instrumentation-hook - register-once', () => {
     await next.fetch('/foo')
     expect(next.cliOutput).toIncludeRepeated('register-log', 1)
   })
+
+  it('should not error when concurrent requests are made', async () => {
+    await Promise.all([next.fetch('/foo'), next.fetch('/foo')])
+    expect(next.cliOutput).toIncludeRepeated('register-log', 1)
+    expect(next.cliOutput).not.toInclude('duplicated-register')
+  })
 })