avoid inheriting span into effect

That only causes incomplete spans in the tracing when the Span is cached.
vercel · Jan 22, 2025 · a21022b · a21022b
1 parent d12e2e8
commit a21022b
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/turbopack/crates/turbo-tasks/src/effect.rs b/turbopack/crates/turbo-tasks/src/effect.rs
@@ -30,7 +30,6 @@ type EffectFuture = Pin<Box<dyn Future<Output = Result<()>> + Send + Sync + 'sta
 /// The inner state of an effect instance if it has not been applied yet.
 struct EffectInner {
     future: EffectFuture,
-    span: Span,
 }
 
 enum EffectState {
@@ -51,7 +50,6 @@ impl EffectInstance {
         Self {
             inner: Mutex::new(EffectState::NotStarted(EffectInner {
                 future: Box::pin(future),
-                span: Span::current(),
             })),
         }
     }
@@ -87,10 +85,10 @@ impl EffectInstance {
                 State::Started(listener) => {
                     listener.await;
                 }
-                State::NotStarted(EffectInner { future, span }) => {
+                State::NotStarted(EffectInner { future }) => {
                     let join_handle = tokio::spawn(
                         turbo_tasks_future_scope(turbo_tasks::turbo_tasks(), future)
-                            .instrument(span),
+                            .instrument(Span::current()),
                     );
                     let result = match join_handle.await {
                         Ok(Err(err)) => Err(SharedError::new(err)),