isNewDevOverlay value should be __NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY

vercel · Jan 22, 2025 · 57cb856 · 57cb856
1 parent a46dd39
commit 57cb856
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/test/development/app-dir/owner-stack/owner-stack.test.ts b/test/development/app-dir/owner-stack/owner-stack.test.ts
@@ -49,7 +49,7 @@ describe('app-dir - owner-stack', () => {
     files: __dirname,
   })
 
-  const isNewDevOverlay = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+  const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
 
   it('should log stitched error for browser uncaught errors', async () => {
     const browser = await next.browser('/browser/uncaught')

diff --git a/test/development/app-dir/prerender-indicator/prerender-indicator.test.ts b/test/development/app-dir/prerender-indicator/prerender-indicator.test.ts
@@ -7,7 +7,7 @@ describe('prerender indicator', () => {
     files: __dirname,
   })
 
-  const isNewDevOverlay = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+  const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
 
   async function hasStaticIndicator(browser: BrowserInterface) {
     if (isNewDevOverlay) {

diff --git a/...r/server-component-next-dynamic-ssr-false/server-component-next-dynamic-ssr-false.test.ts b/...r/server-component-next-dynamic-ssr-false/server-component-next-dynamic-ssr-false.test.ts
@@ -6,7 +6,7 @@ import {
 } from 'next-test-utils'
 
 // Enabling PPR testing also enables the new dev overlay.
-const isNewDevOverlay = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
 
 describe('app-dir - server-component-next-dynamic-ssr-false', () => {
   const { next } = nextTestSetup({

diff --git a/test/development/app-dir/ssr-in-rsc/ssr-in-rsc.test.ts b/test/development/app-dir/ssr-in-rsc/ssr-in-rsc.test.ts
@@ -8,7 +8,7 @@ import {
 } from 'next-test-utils'
 
 const isReactExperimental = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
-const isNewDevOverlay = isReactExperimental
+const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
 const isReact18 = parseInt(process.env.NEXT_TEST_REACT_VERSION) === 18
 
 describe('react-dom/server in React Server environment', () => {

diff --git a/test/e2e/app-dir/error-on-next-codemod-comment/error-on-next-codemod-comment.test.ts b/test/e2e/app-dir/error-on-next-codemod-comment/error-on-next-codemod-comment.test.ts
@@ -13,7 +13,7 @@ describe('app-dir - error-on-next-codemod-comment', () => {
     skipDeployment: true,
   })
 
-  const isNewDevOverlay = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+  const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
 
   if (isNextDev) {
     beforeAll(async () => {

diff --git a/test/e2e/app-dir/use-cache-unknown-cache-kind/use-cache-unknown-cache-kind.test.ts b/test/e2e/app-dir/use-cache-unknown-cache-kind/use-cache-unknown-cache-kind.test.ts
@@ -29,7 +29,7 @@ describe('use-cache-unknown-cache-kind', () => {
     return
   }
 
-  const isNewDevOverlay = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+  const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
 
   if (isNextStart) {
     it('should fail the build with an error', async () => {

diff --git a/test/e2e/app-dir/use-cache-without-dynamic-io/use-cache-without-dynamic-io.test.ts b/test/e2e/app-dir/use-cache-without-dynamic-io/use-cache-without-dynamic-io.test.ts
@@ -24,7 +24,7 @@ describe('use-cache-without-dynamic-io', () => {
     return
   }
 
-  const isNewDevOverlay = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+  const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
 
   if (isNextStart) {
     it('should fail the build with an error', async () => {

diff --git a/test/lib/next-test-utils.ts b/test/lib/next-test-utils.ts
@@ -990,7 +990,7 @@ export function getRedboxFloatingHeaderText(
 
 export async function getRedboxTotalErrorCount(browser: BrowserInterface) {
   // TODO(jiwon): Remove this once we have a new dev overlay at stable.
-  const isNewDevOverlay = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+  const isNewDevOverlay = !!process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
   if (isNewDevOverlay) {
     // N/M\nNext.js X.Y.Z -> M
     const text = (await getRedboxFloatingHeaderText(browser)) || ''