no devTools yet

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
vercel · Jan 23, 2025 · 288c3d0 · 288c3d0
1 parent 557e370
commit 288c3d0
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 24 deletions.
diff --git a/packages/next/src/client/components/react-dev-overlay/_experimental/app/error-boundary.tsx b/packages/next/src/client/components/react-dev-overlay/_experimental/app/error-boundary.tsx
@@ -3,14 +3,14 @@ import type { GlobalErrorComponent } from '../../../error-boundary'
 import { PureComponent } from 'react'
 import { RuntimeErrorHandler } from '../../../errors/runtime-error-handler'
 
-type DevToolsErrorBoundaryProps = {
+type DevOverlayErrorBoundaryProps = {
   children: React.ReactNode
-  devTools: React.ReactNode
+  devOverlay: React.ReactNode
   globalError: [GlobalErrorComponent, React.ReactNode]
   onError: (value: boolean) => void
 }
 
-type DevToolsErrorBoundaryState = {
+type DevOverlayErrorBoundaryState = {
   isReactError: boolean
   reactError: unknown
 }
@@ -38,9 +38,9 @@ function ErroredHtml({
   )
 }
 
-export class DevToolsErrorBoundary extends PureComponent<
-  DevToolsErrorBoundaryProps,
-  DevToolsErrorBoundaryState
+export class DevOverlayErrorBoundary extends PureComponent<
+  DevOverlayErrorBoundaryProps,
+  DevOverlayErrorBoundaryState
 > {
   state = { isReactError: false, reactError: null }
 
@@ -62,7 +62,7 @@ export class DevToolsErrorBoundary extends PureComponent<
   }
 
   render() {
-    const { children, globalError, devTools } = this.props
+    const { children, globalError, devOverlay } = this.props
     const { isReactError, reactError } = this.state
 
     const fallback = (
@@ -72,7 +72,7 @@ export class DevToolsErrorBoundary extends PureComponent<
     return (
       <>
         {isReactError ? fallback : children}
-        {devTools}
+        {devOverlay}
       </>
     )
   }

diff --git a/...ages/next/src/client/components/react-dev-overlay/_experimental/app/react-dev-overlay.tsx b/...ages/next/src/client/components/react-dev-overlay/_experimental/app/react-dev-overlay.tsx
@@ -2,7 +2,7 @@ import type { OverlayState } from '../../shared'
 import type { GlobalErrorComponent } from '../../../error-boundary'
 
 import { useState } from 'react'
-import { DevToolsErrorBoundary } from './error-boundary'
+import { DevOverlayErrorBoundary } from './error-boundary'
 import { ShadowPortal } from '../internal/components/shadow-portal'
 import { Base } from '../internal/styles/base'
 import { ComponentStyles } from '../internal/styles/component-styles'
@@ -24,7 +24,7 @@ export default function ReactDevOverlay({
   const [isErrorOverlayOpen, setIsErrorOverlayOpen] = useState(false)
   const { readyErrors } = useErrorHook({ errors: state.errors, isAppDir: true })
 
-  const devTools = (
+  const devOverlay = (
     <ShadowPortal>
       <CssReset />
       <Base />
@@ -47,12 +47,12 @@ export default function ReactDevOverlay({
   )
 
   return (
-    <DevToolsErrorBoundary
-      devTools={devTools}
+    <DevOverlayErrorBoundary
+      devOverlay={devOverlay}
       globalError={globalError}
       onError={setIsErrorOverlayOpen}
     >
       {children}
-    </DevToolsErrorBoundary>
+    </DevOverlayErrorBoundary>
   )
 }
diff --git a/packages/next/src/client/components/react-dev-overlay/_experimental/pages/error-boundary.tsx b/packages/next/src/client/components/react-dev-overlay/_experimental/pages/error-boundary.tsx
@@ -1,15 +1,15 @@
 import * as React from 'react'
 
-type DevToolsErrorBoundaryProps = {
+type DevOverlayErrorBoundaryProps = {
   children?: React.ReactNode
   onError: (error: Error, componentStack: string | null) => void
   isMounted?: boolean
 }
-type DevToolsErrorBoundaryState = { error: Error | null }
+type DevOverlayErrorBoundaryState = { error: Error | null }
 
-export class DevToolsErrorBoundary extends React.PureComponent<
-  DevToolsErrorBoundaryProps,
-  DevToolsErrorBoundaryState
+export class DevOverlayErrorBoundary extends React.PureComponent<
+  DevOverlayErrorBoundaryProps,
+  DevOverlayErrorBoundaryState
 > {
   state = { error: null }
 

diff --git a/...es/next/src/client/components/react-dev-overlay/_experimental/pages/react-dev-overlay.tsx b/...es/next/src/client/components/react-dev-overlay/_experimental/pages/react-dev-overlay.tsx
@@ -6,7 +6,7 @@ import { Base } from '../internal/styles/base'
 import { ComponentStyles } from '../internal/styles/component-styles'
 import { CssReset } from '../internal/styles/css-reset'
 
-import { DevToolsErrorBoundary } from './error-boundary'
+import { DevOverlayErrorBoundary } from './error-boundary'
 import { usePagesReactDevOverlay } from '../../pages/hooks'
 import { Colors } from '../internal/styles/colors'
 import { ErrorOverlay } from '../internal/components/errors/error-overlay/error-overlay'
@@ -37,9 +37,9 @@ export default function ReactDevOverlay({ children }: ReactDevOverlayProps) {
 
   return (
     <>
-      <DevToolsErrorBoundary isMounted={isMounted} onError={onComponentError}>
+      <DevOverlayErrorBoundary isMounted={isMounted} onError={onComponentError}>
         {children ?? null}
-      </DevToolsErrorBoundary>
+      </DevOverlayErrorBoundary>
 
       {isMounted && (
         <ShadowPortal>

diff --git a/test/development/app-dir/owner-stack/owner-stack.test.ts b/test/development/app-dir/owner-stack/owner-stack.test.ts
@@ -88,7 +88,7 @@ describe('app-dir - owner-stack', () => {
           at renderRootSync 
           at performWorkOnRoot 
           at performWorkOnRootViaSchedulerTask 
-          at MessagePort.performWorkUntilDeadline  The above error occurred in the <Page> component. It was handled by the <DevToolsErrorBoundary> error boundary."
+          at MessagePort.performWorkUntilDeadline  The above error occurred in the <Page> component. It was handled by the <DevOverlayErrorBoundary> error boundary."
         `)
       } else {
         expect(normalizeStackTrace(errorLog)).toMatchInlineSnapshot(`
@@ -107,7 +107,7 @@ describe('app-dir - owner-stack', () => {
           at renderRootSync 
           at performWorkOnRoot 
           at performWorkOnRootViaSchedulerTask 
-          at MessagePort.performWorkUntilDeadline  The above error occurred in the <Page> component. It was handled by the <DevToolsErrorBoundary> error boundary."
+          at MessagePort.performWorkUntilDeadline  The above error occurred in the <Page> component. It was handled by the <DevOverlayErrorBoundary> error boundary."
       `)
       }
     } else {
@@ -238,7 +238,7 @@ describe('app-dir - owner-stack', () => {
        at renderRootSync 
        at performWorkOnRoot 
        at performWorkOnRootViaSchedulerTask 
-       at MessagePort.performWorkUntilDeadline  The above error occurred in the <Page> component. It was handled by the <DevToolsErrorBoundary> error boundary."
+       at MessagePort.performWorkUntilDeadline  The above error occurred in the <Page> component. It was handled by the <DevOverlayErrorBoundary> error boundary."
       `)
     } else {
       expect(normalizeStackTrace(errorLog)).toMatchInlineSnapshot(`