Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat uglify-es like uglify-js #446

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Treat uglify-es like uglify-js #446

merged 2 commits into from
Jul 2, 2019

Conversation

guybedford
Copy link
Contributor

Due to the same awful code pattern we can't analyze that makes it unbuildable by Webpack, this extends the uglify-js treatment to uglify-es.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files          13       13           
  Lines         395      395           
=======================================
  Hits          295      295           
  Misses        100      100
Impacted Files Coverage Δ
src/loaders/empty-loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bba8cf...7e2b043. Read the comment docs.

@styfle styfle merged commit d928b4f into master Jul 2, 2019
@styfle styfle deleted the uglify-es branch July 2, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants