Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat uglify-js as empty by default #307

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Treat uglify-js as empty by default #307

merged 1 commit into from
Mar 14, 2019

Conversation

guybedford
Copy link
Contributor

This fixes the pug build, by always ignoring uglify-js builds. I know it doesn't sound ideal, but that really is the best fix we can come up with here given there isn't an analysis solution with the current technology.

When this happens the following warning is output:

ncc: Ignoring build of uglify-js, as it is not statically analyzable. Build with "--external uglify-js" if this package is needed.

@guybedford guybedford mentioned this pull request Mar 14, 2019
@rauchg
Copy link
Member

rauchg commented Mar 14, 2019

I think this is a good solution for now, considering the popularity of the module

@codecov-io
Copy link

Codecov Report

Merging #307 into master will increase coverage by 1.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   66.76%   68.37%   +1.61%     
==========================================
  Files          11       12       +1     
  Lines         352      370      +18     
==========================================
+ Hits          235      253      +18     
  Misses        117      117
Impacted Files Coverage Δ
src/index.js 69.53% <ø> (ø) ⬆️
src/loaders/empty-loader.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d4a92...b6bc245. Read the comment docs.

@rauchg rauchg merged commit a2ea9b4 into master Mar 14, 2019
@rauchg rauchg deleted the uglifyjs-external branch March 14, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants