-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drawBoldTextInBrightColors
setting
#7019
base: canary
Are you sure you want to change the base?
Add drawBoldTextInBrightColors
setting
#7019
Conversation
drawBoldTextInBrightColors
setting
Thanks for the contribution, the new config structure is not fully finalized, I'm thinking of grouping some xterm related options in a separate key. I'll keep this pr open till the structure is finalized and then we can work on getting this merged. |
Hi, I just want to follow up on this thread. Is the new config structure fully finalized now so that this configuration option can be added? I tested the changes in this PR (with some minor modifications) on my local branch and it worked as expected. It will be great to have this feature in the released version so that I don't have to run my local build. Thanks! |
8683db0
to
d9d5ce2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @comicchang for making this work! Just a minor comment regarding the code.
Signed-off-by: Comic Chang <comicchang@gmail.com>
d9d5ce2
to
82728ad
Compare
@weiqisun Thanks for your comment, fixed. |
This PR adds a option to set drawBoldTextInBrightColors to xterm.js.
This should resolve #5361 #2836 ##973
Example
hyper.json
current master
or
this PR with
drawBoldTextInBrightColors: true
this PR with
drawBoldTextInBrightColors: false