Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drawBoldTextInBrightColors setting #7019

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

comicchang
Copy link

@comicchang comicchang commented Feb 8, 2023

This PR adds a option to set drawBoldTextInBrightColors to xterm.js.

This should resolve #5361 #2836 ##973

Example hyper.json

{
  "$schema": "./schema.json",
  "config": {
    "drawBoldTextInBrightColors": false,
    "colors": {
      "black": "#073642",
      "red": "#dc322f",
      "green": "#859900",
      "yellow": "#b58900",
      "blue": "#268bd2",
      "magenta": "#d33682",
      "cyan": "#2aa198",
      "white": "#eee8d5",
      "lightBlack": "#586e75",
      "lightRed": "#cb4b16",
      "lightGreen": "#586e75",
      "lightYellow": "#657b83",
      "lightBlue": "#839496",
      "lightMagenta": "#6c71c4",
      "lightCyan": "#93a1a1",
      "lightWhite": "#fdf6e3",
      "limeGreen": "#32CD32",
      "lightCoral": "#F08080"
    },
...
  },
...
}

current master
or
this PR with drawBoldTextInBrightColors: true
image

this PR with drawBoldTextInBrightColors: false
image

@comicchang comicchang closed this Feb 8, 2023
@comicchang comicchang reopened this Feb 8, 2023
@comicchang comicchang changed the title add option drawBoldTextInBrightColors Add drawBoldTextInBrightColors setting Feb 8, 2023
@LabhanshAgrawal
Copy link
Collaborator

Thanks for the contribution, the new config structure is not fully finalized, I'm thinking of grouping some xterm related options in a separate key. I'll keep this pr open till the structure is finalized and then we can work on getting this merged.

@weiqisun
Copy link

weiqisun commented Feb 6, 2024

Hi, I just want to follow up on this thread. Is the new config structure fully finalized now so that this configuration option can be added? I tested the changes in this PR (with some minor modifications) on my local branch and it worked as expected. It will be great to have this feature in the released version so that I don't have to run my local build. Thanks!

@comicchang comicchang force-pushed the add_drawBoldTextInBrightColors_option branch from 8683db0 to d9d5ce2 Compare February 7, 2024 01:24
Copy link

@weiqisun weiqisun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @comicchang for making this work! Just a minor comment regarding the code.

typings/config.d.ts Outdated Show resolved Hide resolved
typings/hyper.d.ts Outdated Show resolved Hide resolved
Signed-off-by: Comic Chang <comicchang@gmail.com>
@comicchang comicchang force-pushed the add_drawBoldTextInBrightColors_option branch from d9d5ce2 to 82728ad Compare February 7, 2024 01:48
@comicchang
Copy link
Author

@weiqisun Thanks for your comment, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable bold text changing to bright colors
3 participants