Skip to content

Commit

Permalink
Upgrade electron to 1.6.8 (#1848)
Browse files Browse the repository at this point in the history
* Upgrade deps

* Remove --harmony flag

* Add --harmony-async-await flag

* Pin deps

* Use cheap-module-source-map for dev

See webpack/webpack#2145 (comment)

* Update yarn.lock
  • Loading branch information
albinekb authored and rauchg committed May 20, 2017
1 parent 55345eb commit e09a7f7
Show file tree
Hide file tree
Showing 4 changed files with 162 additions and 127 deletions.
2 changes: 1 addition & 1 deletion app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const createRPC = require('./rpc');
const notify = require('./notify');
const fetchNotifications = require('./notifications');

app.commandLine.appendSwitch('js-flags', '--harmony');
app.commandLine.appendSwitch('js-flags', '--harmony-async-await');

// set up config
const config = require('./config');
Expand Down
20 changes: 13 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@
"minify-flip-comparisons",
"minify-guarded-expressions",
"minify-infinity",
["minify-mangle-names", { "keepClassName": true, "keepFnName": true }],
[
"minify-mangle-names",
{
"keepClassName": true,
"keepFnName": true
}
],
"minify-replace",
"minify-simplify",
"minify-type-constructors",
Expand Down Expand Up @@ -117,18 +123,18 @@
},
"devDependencies": {
"ava": "0.17.0",
"babel-cli": "6.18.0",
"babel-core": "6.18.0",
"babel-cli": "6.24.1",
"babel-core": "6.24.1",
"babel-loader": "6.2.10",
"babel-preset-babili": "0.0.9",
"babel-preset-react": "6.16.0",
"babel-preset-babili": "0.0.12",
"babel-preset-react": "6.24.1",
"copy-webpack-plugin": "4.0.0",
"cross-env": "3.1.3",
"electron": "1.4.16",
"electron": "1.6.8",
"electron-builder": "13.6.0",
"electron-builder-squirrel-windows": "13.6.1",
"electron-devtools-installer": "2.0.0",
"electron-rebuild": "1.5.10",
"electron-builder-squirrel-windows": "13.6.1",
"eslint-config-xo-react": "0.10.0",
"eslint-plugin-react": "6.7.1",
"husky": "0.11.6",
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const nodeEnv = process.env.NODE_ENV || 'development';
const isProd = nodeEnv === 'production';

module.exports = {
devtool: isProd ? 'hidden-source-map' : 'cheap-eval-source-map',
devtool: isProd ? 'hidden-source-map' : 'cheap-module-source-map',
entry: './lib/index.js',
output: {
path: path.join(__dirname, 'app', 'dist'),
Expand Down
Loading

0 comments on commit e09a7f7

Please sign in to comment.