Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dynamism in imports #351

Merged
merged 2 commits into from
May 28, 2023
Merged

remove dynamism in imports #351

merged 2 commits into from
May 28, 2023

Conversation

Schniz
Copy link
Collaborator

@Schniz Schniz commented May 28, 2023

this PR removes the required (explicit) file system read in favor of static require calls,
which is practically an implicit file system read, but statically analyzable by bundlers.

@Schniz Schniz self-assigned this May 28, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 28, 2023

🦋 Changeset detected

Latest commit: 4e10f04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@edge-runtime/primitives Patch
@edge-runtime/types Patch
@edge-runtime/vm Patch
@edge-runtime/jest-environment Patch
edge-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
edge-runtime ✅ Ready (Inspect) Visit Preview May 28, 2023 8:04am

@Schniz Schniz merged commit 8d4f786 into main May 28, 2023
@Schniz Schniz deleted the remove-dynamism-in-imports branch May 28, 2023 08:07
@Schniz
Copy link
Collaborator Author

Schniz commented May 28, 2023

working on sunday be like
image

This was referenced May 28, 2023
jridgewell pushed a commit to jridgewell/edge-runtime that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant