extract primitives/load function #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when trying to upgrade Next.js a test failed that showed that Uint8Array usage is problematic with the crypto module. This is because the crypto polyfill is checking `instanceof` of the input values, and sadly, the Uint8Arrays constructed frmo the EdgeVM context do not satisfy that condition. In order to change it, I decided to use the requireWithFakeGlobalScope yet again in the VM module, but instead of re-implementing it, I extracted the `load` function, which is just like the `primitives` entrypoint, only lazy--and receives the scopedContext, which will act as a global context for the requires The types that are being used in the scopedContext are the same ones we patch for the `instanceof` checks ourselves, which makes sense! This fixes the test so we should be safer now!
🦋 Changeset detectedLatest commit: b70b456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…-to-shadow-over-globals
Merged
Merged
jridgewell
pushed a commit
to jridgewell/edge-runtime
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when trying to upgrade Next.js a test failed that showed that Uint8Array usage is problematic
with the crypto module. This is because the crypto polyfill is checking
instanceofof theinput values, and sadly, the Uint8Arrays constructed frmo the EdgeVM context do not satisfy
that condition.
In order to change it, I decided to use the requireWithFakeGlobalScope yet again in the VM
module, but instead of re-implementing it, I extracted the
loadfunction, which is justlike the
primitivesentrypoint, only lazy--and receives the scopedContext, which willact as a global context for the requires
The types that are being used in the scopedContext are the same ones we patch for the
instanceofchecks ourselves, which makes sense!This fixes the test so we should be safer now!