-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update dependencies #258
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -30,13 +30,13 @@ | |||
"blob-polyfill": "7.0.20220408", | |||
"esbuild-plugin-alias": "latest", | |||
"event-target-shim": "6.0.2", | |||
"formdata-node": "4.4.1", | |||
"formdata-node": "5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v5 is dropping node12 and use ESM; we have to be sure ESM is converted to CommonJS by our TS build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested via REPL:
~/vercel/edge-runtime/packages/runtime primitives ≡
❯ node dist/cli/repl.js
ƒ => const formData = new FormData();
undefined
ƒ => formData
FormData { [Symbol(state)]: [] }
ƒ => formData.append('foo', 'bar')
undefined
ƒ => formData
FormData { [Symbol(state)]: [ { name: 'foo', value: 'bar' } ] }
ƒ =>
"web-streams-polyfill": "4.0.0-beta.3", | ||
"whatwg-url": "11.0.0" | ||
"whatwg-url": "12.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
essentially dropping node12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related with the dependency upgrade, but CLI is not printing URL as expected:
ƒ => new URL('https://example.com')
URL { }
ƒ => const url = new URL('https://example.com')
undefined
ƒ => url
URL { }
ƒ =>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
No description provided.