Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependencies #258

Merged
merged 1 commit into from
Feb 7, 2023
Merged

build: update dependencies #258

merged 1 commit into from
Feb 7, 2023

Conversation

Kikobeats
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2023

⚠️ No Changeset found

Latest commit: b827983

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
edge-runtime ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 10:57AM (UTC)

@@ -30,13 +30,13 @@
"blob-polyfill": "7.0.20220408",
"esbuild-plugin-alias": "latest",
"event-target-shim": "6.0.2",
"formdata-node": "4.4.1",
"formdata-node": "5.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5 is dropping node12 and use ESM; we have to be sure ESM is converted to CommonJS by our TS build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested via REPL:

~/vercel/edge-runtime/packages/runtime primitives ≡
❯ node dist/cli/repl.js
ƒ => const formData = new FormData();
undefined
ƒ => formData
FormData { [Symbol(state)]: [] }
ƒ => formData.append('foo', 'bar')
undefined
ƒ => formData
FormData { [Symbol(state)]: [ { name: 'foo', value: 'bar' } ] }
ƒ =>

"web-streams-polyfill": "4.0.0-beta.3",
"whatwg-url": "11.0.0"
"whatwg-url": "12.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

essentially dropping node12

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related with the dependency upgrade, but CLI is not printing URL as expected:

ƒ => new URL('https://example.com')
URL {  }
ƒ => const url = new URL('https://example.com')
undefined
ƒ => url
URL {  }
ƒ =>

Copy link
Member

@feugy feugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Kikobeats Kikobeats merged commit 715c80c into main Feb 7, 2023
@Kikobeats Kikobeats deleted the primitives branch February 7, 2023 12:49
@Kikobeats Kikobeats restored the primitives branch February 7, 2023 12:52
jridgewell pushed a commit to jridgewell/edge-runtime that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants