feat(node-utils): uses host header and mocks waitUntil() #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d3806d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feugy
force-pushed
the
damien/ec-475-add-support-for-web-signature-in
branch
from
72a8997 to
79c3ec1
Compare
Kikobeats
approved these changes
Jan 25, 2023
Merged
jridgewell
pushed a commit
to jridgewell/edge-runtime
that referenced
this pull request
Jun 23, 2023
* feat(node-utils): uses incoming host header to determine request's origin * feat(node-utils): provides mocked fetch event which throws on waitUntil accesses * fix(ci): reverts failing version bump for jest * chore(ci): fixes poisoned turbo cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 What's in there?
Current node-utils have a fixed origin for mapped web requests. A better solution is to leverage the incomingMessage's
hostheader, and only default to a fixed value in case the header is missing.This PR also brings a mocked
fetchEvent(web handler second parameter). It will throw when usingwaitUntil(), so our users would know this feature is not implemented yet.📓 Notes to reviewers
It is likely that no one is using this package. Yet, these are 2 breaking changes, since the required options and dependencies have changed.
Please hide whitespace changes when reviewing, to find the actual changes.