-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-utils): introduces @edge-runtime/node-utils to run edge compliant code in Node.js environment #219
Conversation
🦋 Changeset detectedLatest commit: cc38884 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a308d1d
to
7322e38
Compare
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 88.51% 90.67% +2.15%
==========================================
Files 14 11 -3
Lines 1280 343 -937
Branches 67 34 -33
==========================================
- Hits 1133 311 -822
+ Misses 143 32 -111
+ Partials 4 0 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Will take a look further so leaving some nitpicks for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left some nitpicks.
1c7e52a
to
3008c78
Compare
5ce56da
to
cc38884
Compare
…pliant code in Node.js environment (vercel#219) chore(node-utils): introduces edge-related utilities chore(primitives): improves `fetch` type chore: only considers src/ folder when running coverage with jest chore(ponyfill): ignores types for fetch parameters doc(node-utils): adds README and documentation page Co-authored-by: Javi Velasco <javier.velasco86@gmail.com> Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
📖 What's in there?
Utility functions that we need for executing edge-related code on server side.
🧪 How to try?
This will be used in Next.js and @vercel/node-bridge.
They are fully covered with unit tests, have a look a
edge-to-node/handler.test.ts
Documentation is available here