Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Drop Node.js 12 #191

Merged
merged 15 commits into from
Oct 27, 2022
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 26, 2022

This PR contains:

Related

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022

🦋 Changeset detected

Latest commit: 431fec9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
edge-runtime ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 2:19PM (UTC)

@styfle styfle changed the title Drop nodejs 12 BREAKING CHANGE: Drop Node.js 12 Oct 26, 2022
@Kikobeats
Copy link
Member

hum, something related with jest integration is not working fine:

npx jest --detectOpenHandles
 PASS  test/index.test.ts
  ✓ TextEncoder references the same global Uint8Array constructor (2 ms)
  ✓ allows to run fetch (290 ms)
  ✓ allows to run crypto
  ✓ has EdgeRuntime global (1 ms)

Test Suites: 1 passed, 1 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        0.875 s, estimated 1 s
Ran all test suites.

Jest has detected the following 1 open handle potentially keeping Jest from exiting:

  ●  TCPWRAP

      at Client.connect (evalmachine.<anonymous>:9471:24)
      at socket (evalmachine.<anonymous>:10877:29)
      at connect (evalmachine.<anonymous>:10876:30)
      at _resume (evalmachine.<anonymous>:11035:11)
      at resume (evalmachine.<anonymous>:10961:7)
      at Client.[dispatch] (evalmachine.<anonymous>:10303:11)
      at Intercept (evalmachine.<anonymous>:10052:20)
      at Client.[Intercepted Dispatch] (evalmachine.<anonymous>:8927:16)
      at Client.dispatch (evalmachine.<anonymous>:8943:44)
      at Pool.[dispatch] (evalmachine.<anonymous>:9168:32)
      at Pool.[Intercepted Dispatch] (evalmachine.<anonymous>:8920:33)
      at Pool.dispatch (evalmachine.<anonymous>:8943:44)
      at Agent2.[dispatch] (evalmachine.<anonymous>:11580:27)
      at Intercept (evalmachine.<anonymous>:10052:20)
      at Agent2.[Intercepted Dispatch] (evalmachine.<anonymous>:8927:16)
      at Agent2.dispatch (evalmachine.<anonymous>:8943:44)
      at evalmachine.<anonymous>:8669:83
      at dispatch (evalmachine.<anonymous>:8669:16)
      at httpNetworkFetch (evalmachine.<anonymous>:8570:65)
      at httpNetworkOrCacheFetch (evalmachine.<anonymous>:8461:39)
      at httpFetch (evalmachine.<anonymous>:8301:43)
      at schemeFetch (evalmachine.<anonymous>:8234:24)
      at evalmachine.<anonymous>:8107:26
      at mainFetch (evalmachine.<anonymous>:8126:11)
      at fetching (evalmachine.<anonymous>:8080:7)
      at Agent2.fetch (evalmachine.<anonymous>:7945:20)
      at fetch (evalmachine.<anonymous>:11739:40)
      at Object.fetch (test/index.test.ts:10:26)

@Kikobeats Kikobeats merged commit dfa837e into vercel:main Oct 27, 2022
@styfle styfle deleted the remove-node12 branch October 27, 2022 14:24
@Kikobeats Kikobeats mentioned this pull request Oct 27, 2022
jridgewell pushed a commit to jridgewell/edge-runtime that referenced this pull request Jun 23, 2023
* Drop nodejs 12

* refactor: add @jest/type back

* refactor: extract target as constant

* fix: pass allow to access to util/types

* refactor: remove uuid dependency

* ci: drop node12

* refactor: add util/types for node14

* refactor: update jest dependencies

* refactor: add jest setup back

* refactor: remove wrong file

* remove missing api

* use example.vercel.sh

* test: update snapshot

* test: delete jest workaround

* Create olive-rivers-tease.md

Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop node12 support
2 participants