Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cookies): align RequestCookies with ResponseCookies #187

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

balazsorban44
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

🦋 Changeset detected

Latest commit: d95e7a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@edge-runtime/cookies Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
edge-runtime ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 9:34PM (UTC)

@balazsorban44 balazsorban44 changed the title feat(cookies): align RequestCookies with ResponseCookies feat(cookies): align RequestCookies with ResponseCookies Oct 24, 2022
@balazsorban44 balazsorban44 marked this pull request as ready for review October 24, 2022 21:11
@codecov-commenter
Copy link

Codecov Report

Merging #187 (d95e7a7) into main (94ad6e1) will decrease coverage by 0.57%.
The diff coverage is 77.11%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   87.91%   87.33%   -0.58%     
==========================================
  Files          14       11       -3     
  Lines        1704     1058     -646     
  Branches      213       66     -147     
==========================================
- Hits         1498      924     -574     
+ Misses        192      128      -64     
+ Partials       14        6       -8     
Impacted Files Coverage Δ
packages/cookies/src/request-cookies.ts 63.96% <63.96%> (ø)
packages/cookies/src/response-cookies.ts 72.07% <72.07%> (ø)
packages/jest-environment/src/index.ts 99.31% <75.00%> (-0.69%) ⬇️
packages/vm/src/edge-vm.ts 95.82% <87.87%> (+2.31%) ⬆️
packages/cookies/src/serialize.ts 93.58% <93.58%> (ø)
jest.setup.js 100.00% <100.00%> (ø)
packages/cookies/src/cached.ts 100.00% <100.00%> (ø)
packages/vm/src/temp-file.ts 55.55% <0.00%> (-38.89%) ⬇️
packages/vm/src/vm.ts 90.34% <0.00%> (-4.83%) ⬇️
packages/vm/src/require.ts 77.17% <0.00%> (-3.27%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@balazsorban44 balazsorban44 changed the title feat(cookies): align RequestCookies with ResponseCookies fix(cookies): align RequestCookies with ResponseCookies Oct 24, 2022
@Kikobeats Kikobeats self-requested a review October 24, 2022 21:42
@Kikobeats Kikobeats merged commit 473831f into vercel:main Oct 24, 2022
@balazsorban44 balazsorban44 deleted the feat/align-request-cookies branch October 24, 2022 21:43
@Kikobeats Kikobeats mentioned this pull request Oct 24, 2022
jridgewell pushed a commit to jridgewell/edge-runtime that referenced this pull request Jun 23, 2023
* feat(cookies): align `RequestCookies` with ResponseCookies

* add changeset

* update docs with cookie methods

* re-add some doc

* revert formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants